Update OpenROAD (The-OpenROAD-Project#2062)

~ openroad_app -> `75f2f32`

## CI
~ Always compare regression and create reproducibles
~ Always escape design name
+ Add tests for attached crashes by adding issues reproducibles in designs submodules and symlink them to interactive scripts under ./tests
+ Fix failing designs in extended test:
  * salsa20: setup violations
  * y_huff: routing congestion
  * aes_core: pin antenna violations benchmark mismatch

.github/scripts/run_tests.py

@@ -104,10 +104,6 @@ def cat(x):
 )
 print("Created ./reproducible.tar.gz.")
 
-if run_return_code != 0:
-    print("Run failed")
-    raise run_exception
-
 difference_reports = glob.glob(os.path.join(results_folder, f"{test_name}*.rpt"))
 if len(difference_reports):
     print("Verbose differences within the benchmark:")
@@ -125,4 +121,8 @@ def cat(x):
         print("Testing the design has failed.")
         exit(-1)
 
+if run_return_code != 0:
+    print("Run failed")
+    raise run_exception
+
 print("Done.")

.github/workflows/openlane_ci.yml

@@ -141,6 +141,8 @@ jobs:
       matrix: ${{ fromJSON(needs.prepare_test_matrices.outputs.issue_regression_matrix) }}
     steps:
       - uses: actions/checkout@v3
+        with:
+          submodules: true
 
       - name: Set up environment variables
         uses: ./.github/actions/set_env_variables
@@ -233,6 +235,7 @@ jobs:
             python3 ${GITHUB_WORKSPACE}/.github/scripts/run_tests.py ${{ matrix.design.name }}
 
       - name: Escape Design Name
+        if: ${{ always() }}
         run: |
           design_name=${{ matrix.design.name }}
           escaped_design_name=${design_name//\//_}

dependencies/tool_metadata.yml

@@ -56,7 +56,7 @@
   in_install: false
 - name: openroad_app
   repo: https://github.com/The-OpenROAD-Project/OpenROAD
-  commit: 6f9b2bb8b808b1bb5831d4525d868212ae50517a
+  commit: 75f2f325b7a42e56a92404f33af8e96530d9b202
   in_install: false
 - name: git
   repo: https://github.com/git/git

run_designs.py

@@ -398,7 +398,7 @@ def run_design(designs_queue):
                         design,
                         f"Failed to compare with benchmark: {error_msg}",
                     )
-                    flow_failure_flag = True
+                    design_failure_flag = True
 
             if delete:
                 try:

tests/1935-cts-crash/interactive.tcl

@@ -0,0 +1,3 @@
+exec bash -c "set -e && \
+    cd [file dirname [file normalize [info script]]]/reproducible && \ 
+    tar xvf issue.tar.gz && cd issue_reproducible && bash run.sh"

tests/1935-cts-crash/reproducible

@@ -0,0 +1 @@
+../../designs/ci/reproducibles/1935/

tests/2060-resizer-crash/interactive.tcl

@@ -0,0 +1,2 @@
+exec bash -c "set -e && \
+    cd [file dirname [file normalize [info script]]]/reproducible && bash run.sh"

tests/2060-resizer-crash/reproducible

@@ -0,0 +1 @@
+../../designs/ci/reproducibles/2060/issue_reproducible

tests/2065-resizer-crash/interactive.tcl

@@ -0,0 +1,2 @@
+exec bash -c "set -e && \
+    cd [file dirname [file normalize [info script]]]/reproducible && bash run.sh"

tests/2065-resizer-crash/reproducible

@@ -0,0 +1 @@
+../../designs/ci/reproducibles/2065/issue_reproducible