Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: post-drt antenna repair #573

Merged
merged 23 commits into from
Jan 22, 2025
Merged

feat: post-drt antenna repair #573

merged 23 commits into from
Jan 22, 2025

Conversation

kareefardi
Copy link
Collaborator

@kareefardi kareefardi commented Oct 8, 2024 •
edited by donn
Loading

Steps

  • OpenROAD.DetailedRouting
    • Added DRT_SAVE_SNAPSHOTS which enables saving snapshots of the layout each
      detalied routing iteration.
    • Added DRT_ANTENNA_REPAIR_ITERS, which if greater than zero, enables
      antenna fixing after detailed routing
    • Added DRT_ANTENNA_MARGIN which is similar to GRT_ANTENNA_MARGIN but for
      the aforementioned antenna repair iterations

Depends on efabless/openlane2-ci-designs#34
Resolves #610

@kareefardi kareefardi changed the base branch from main to dev October 8, 2024 08:33
@kareefardi
Copy link
Collaborator Author

@donn Thoughts on:

  • Having the step in the classical flow
  • The additional variable DRT_ANTENNA_MARGIN

@openlane-bot
Copy link
Collaborator

openlane-bot commented Oct 8, 2024 •
edited
Loading

Metric comparisons are in beta. Please report bugs under the issues tab.

To create this report yourself, grab the metrics artifact from the CI run, extract them, and invoke python3 -m openlane.common.metrics compare-remote current --branch dev --table-verbosity ALL --table-out ./tables_all.md.

  • Changes to critical metrics were detected in the following designs:
    • sky130A/sky130_fd_sc_hd/MS_SPI_XIP_CACHE

Full tables ► https://gist.github.com/openlane-bot/dc1060a5080590aee8a92b01d8083214

@donn donn changed the title Post drt antenna feat: post-drt antenna repair Oct 9, 2024
@kareefardi kareefardi marked this pull request as ready for review October 14, 2024 12:49
@kareefardi
Merge branch 'dev' into post-drt-antenna
1844ba6
@kareefardi
Merge branch 'dev' into post-drt-antenna
f6265fe
@kareefardi
Merge branch 'dev' into post-drt-antenna
9d6e7bf
@kareefardi
Submodule test/designs: merge origin/dev
cbd8b42 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
Merge remote-tracking branch 'origin/dev' into post-drt-antenna
0a4a8bb
@kareefardi
Merge branch 'dev' into post-drt-antenna
9f4bcd9
@kareefardi
Merge remote-tracking branch 'origin/dev' into post-drt-antenna
00dffa1
@kareefardi
move function of openroad.RepairAntennasPostDRT inside openroad.Detai…
975aea0 
…ledRouting

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
remove all traces of RepairAntennasPostDRT
9a72ae7 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
remove other uneeded code
0e348b1 
update submodule test

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi kareefardi requested a review from donn January 19, 2025 10:12
kareefardi and others added 6 commits January 21, 2025 10:57
@kareefardi
add DRT_ANTENNA_REPAIR_ITERS
02afc79 
rewrite DRT_ANTENNA_REPAIR routine

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
update changelog
da7c049 
bump version

Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
restore old changes in the changelog
db9c4d4 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
restore old changes in the changelog
05d7792 
Signed-off-by: Kareem Farid <[email protected]>
@kareefardi
enable DRT_ANTENNA_REPAIR for a design
3924101 
Signed-off-by: Kareem Farid <[email protected]>
@donn
peer-coding session results
f95d9ed
donn
donn approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@donn donn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@donn donn enabled auto-merge (squash) January 22, 2025 11:09
@donn donn merged commit f6fbadb into dev Jan 22, 2025
109 checks passed
@kareefardi kareefardi mentioned this pull request Feb 12, 2025
Closed
@donn donn deleted the post-drt-antenna branch February 13, 2025 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@donn donn donn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kareefardi @openlane-bot @donn