Skip to content

Conversation

@jbrejner
Copy link
Contributor

This pull request updates multiple Kubernetes documentation files to improve clarity, grammar, and consistency. The changes focus on making instructions easier to follow, correcting typos, and standardizing terminology across the guides.

Documentation improvements:

  • Reworded sentences for clarity and corrected grammar throughout accessing-your-application.md, including improved explanations of port-forwarding, step-by-step instructions, and environment variable usage. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]
  • Enhanced explanations and corrected terminology in configmaps-secrets.md, including clear distinctions between configmaps and secrets, better step-by-step instructions, and more precise descriptions of YAML manifests and environment variable injection. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]

Terminology and consistency fixes:

  • Standardized technical terms and corrected spelling errors in cheatsheet.md, such as "Documentation" and "resource types and abbreviations."
  • Improved terminology in deployments-ingress.md, such as clarifying "load balancing" and using "higher-level abstraction." [1] [2]

@jbrejner jbrejner requested a review from Copilot August 20, 2025 10:37
@jbrejner jbrejner self-assigned this Aug 20, 2025

This comment was marked as outdated.

@jbrejner jbrejner marked this pull request as draft August 20, 2025 10:42
@jbrejner jbrejner force-pushed the jbrejner/markdown_lint_and_grammar branch from 04b0ea5 to 1ac2c2a Compare August 20, 2025 10:50
@jbrejner jbrejner requested a review from Copilot August 20, 2025 10:51

This comment was marked as outdated.

@jbrejner jbrejner force-pushed the jbrejner/markdown_lint_and_grammar branch from 1ac2c2a to 0b659df Compare August 20, 2025 11:05
@jbrejner jbrejner requested a review from Copilot August 20, 2025 11:05

This comment was marked as outdated.

@jbrejner jbrejner marked this pull request as ready for review August 20, 2025 11:07
@jbrejner jbrejner force-pushed the jbrejner/markdown_lint_and_grammar branch from ca7e1f2 to 78097aa Compare August 20, 2025 11:08
Copy link
Contributor

@amrutashety amrutashety left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@michaelin michaelin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was a big one. I've suggested a few rewordings and fixed some extra grammar errors.
I'd suggest adding a GitHub Actions workflow to run a spellchecker in addition to the existing markdownlint workflow

@jbrejner jbrejner force-pushed the jbrejner/markdown_lint_and_grammar branch from 1ed7ef5 to c987da5 Compare August 21, 2025 12:11
@jbrejner jbrejner requested a review from Copilot August 21, 2025 12:12
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request improves Kubernetes documentation clarity and consistency across multiple files. The changes focus on grammar corrections, comma usage improvements, and standardized terminology throughout the guides.

Key changes:

  • Grammar and punctuation improvements for better readability
  • Standardized terminology (e.g., "PostgreSQL" instead of "postgres", "step-by-step" consistently)
  • Enhanced explanations of technical concepts and procedures

Reviewed Changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.

Show a summary per file
File Description
services.md Improved clarity in service discovery explanations and corrected grammar throughout
rolling-updates.md Enhanced rollout instructions and corrected grammar in deployment update procedures
persistent-storage.md Standardized PostgreSQL terminology and improved persistence concept explanations
manifests.md Minor grammar corrections in manifest application instructions
intro.md Improved application deployment explanations and access instructions
exercise-template.md Corrected spelling and improved template structure guidance
desired-state.md Enhanced desired state concept explanations and controller descriptions
deployments-ingress.md Improved deployment and load balancing terminology
configmaps-secrets.md Enhanced ConfigMap and Secret usage explanations
cheatsheet.md Corrected spelling in kubectl command documentation
accessing-your-application.md Improved port-forwarding explanations and step-by-step instructions

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Co-authored-by: Michael Ingeman-Nielsen <[email protected]>
@jbrejner jbrejner force-pushed the jbrejner/markdown_lint_and_grammar branch from 6d54b9e to c55c34a Compare August 21, 2025 13:34
@jbrejner jbrejner merged commit e868f1c into eficode-academy:master Aug 21, 2025
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants