-
Notifications
You must be signed in to change notification settings - Fork 288
Markdown linting and Langauge fixes #123
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Markdown linting and Langauge fixes #123
Conversation
04b0ea5 to
1ac2c2a
Compare
1ac2c2a to
0b659df
Compare
ca7e1f2 to
78097aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was a big one. I've suggested a few rewordings and fixed some extra grammar errors.
I'd suggest adding a GitHub Actions workflow to run a spellchecker in addition to the existing markdownlint workflow
1ed7ef5 to
c987da5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request improves Kubernetes documentation clarity and consistency across multiple files. The changes focus on grammar corrections, comma usage improvements, and standardized terminology throughout the guides.
Key changes:
- Grammar and punctuation improvements for better readability
- Standardized terminology (e.g., "PostgreSQL" instead of "postgres", "step-by-step" consistently)
- Enhanced explanations of technical concepts and procedures
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| services.md | Improved clarity in service discovery explanations and corrected grammar throughout |
| rolling-updates.md | Enhanced rollout instructions and corrected grammar in deployment update procedures |
| persistent-storage.md | Standardized PostgreSQL terminology and improved persistence concept explanations |
| manifests.md | Minor grammar corrections in manifest application instructions |
| intro.md | Improved application deployment explanations and access instructions |
| exercise-template.md | Corrected spelling and improved template structure guidance |
| desired-state.md | Enhanced desired state concept explanations and controller descriptions |
| deployments-ingress.md | Improved deployment and load balancing terminology |
| configmaps-secrets.md | Enhanced ConfigMap and Secret usage explanations |
| cheatsheet.md | Corrected spelling in kubectl command documentation |
| accessing-your-application.md | Improved port-forwarding explanations and step-by-step instructions |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Michael Ingeman-Nielsen <[email protected]>
6d54b9e to
c55c34a
Compare
This pull request updates multiple Kubernetes documentation files to improve clarity, grammar, and consistency. The changes focus on making instructions easier to follow, correcting typos, and standardizing terminology across the guides.
Documentation improvements:
accessing-your-application.md, including improved explanations of port-forwarding, step-by-step instructions, and environment variable usage. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]configmaps-secrets.md, including clear distinctions between configmaps and secrets, better step-by-step instructions, and more precise descriptions of YAML manifests and environment variable injection. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11]Terminology and consistency fixes:
cheatsheet.md, such as "Documentation" and "resource types and abbreviations."deployments-ingress.md, such as clarifying "load balancing" and using "higher-level abstraction." [1] [2]