Fix search on Oban.Pro #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The adapter detection we implemented in 30e2d6c doesn't work for Oban.Pro when one uses the `Smart` engine. Changed to a) assume Postgres for both `Basic` and `Smart`, b) let the fallback also explicitly type cast the jsonb column, which I believe shouldn't matter on sqlite.
redrabbit
approved these changes
Nov 25, 2024
|
Thanks. Just curious, why don't you use also Pro in development? |
|
Nevermind, I double checked and we are using Pro in development. Must have tried it before doing the engine conditional. Thanks for being so quick with the releases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi @egze ,
me again. Patch from this morning fixed it for our app in
:devwhere we use theBasicengine, but not in:prodwhere we have Oban.Pro. 🤦The adapter detection we implemented in 30e2d6c doesn't work for Oban.Pro when one uses the
Smartengine. Changed to a) assume Postgres for bothBasicandSmart, b) let the fallback also explicitly type cast the jsonb column, which I believe shouldn't matter on sqlite.