fix: correct CalorimeterClusterRecoCoG inputs by EDM4eic version #1788
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
topic: calorimetry
Capybara summary for PR 1788
|
|
After this fix, clusters are back: |
wdconinc
force-pushed
the
fixup-CalorimeterClusterRecoCoG
branch
from
625a4a3 to
98f6d9e
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Apr 13, 2025
### Briefly, what does this PR introduce? This PR fixes the inputs used for various CalorimeterClusterRecoCoG factories. Depending on the EDM4eic version, the CalorimeterClusterRecoCoG factory uses different inputs, so we need to respect that. ### What kind of change does this PR introduce? - [x] Bug fix (issue: exceptions in CalorimeterClusterRecoCoG factories) - [ ] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ ] Tests for the changes have been added - [ ] Documentation has been added / updated - [x] Changes have been communicated to collaborators - @veprbl please evaluate for need for backporting into 1.24.1 and 25.04.1 ### Does this PR introduce breaking changes? What changes might users need to make to their code? No. ### Does this PR change default behavior? Yes, will again produce outputs that are currently missing. (cherry picked from commit cacbcc0)
|
Successfully created backport PR for |
7 tasks
wdconinc
added a commit
that referenced
this pull request
Apr 13, 2025
…4eic version (#1794) # Description Backport of #1788 to `v1.24`. Co-authored-by: Wouter Deconinck <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Briefly, what does this PR introduce?
This PR fixes the inputs used for various CalorimeterClusterRecoCoG factories. Depending on the EDM4eic version, the CalorimeterClusterRecoCoG factory uses different inputs, so we need to respect that.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No.
Does this PR change default behavior?
Yes, will again produce outputs that are currently missing.