Skip to content

Restore TaggerTrackerRecHits #1792

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 12, 2025
Merged

Restore TaggerTrackerRecHits #1792

merged 1 commit into from
Apr 12, 2025

Conversation

simonge
Copy link
Contributor

@simonge simonge commented Apr 12, 2025

Briefly, what does this PR introduce?

Fixes the Low-Q2 reconstruction problems outlined here:
#1762 (comment)

Really not sure how these changes snuck in to start with, some bad merging.

What kind of change does this PR introduce?

  • Bug fix (issue #__)
  • New feature (issue #__)
  • Documentation update
  • Other: __

Please check if this PR fulfills the following:

  • Tests for the changes have been added
  • Documentation has been added / updated
  • Changes have been communicated to collaborators

Does this PR introduce breaking changes? What changes might users need to make to their code?

Does this PR change default behavior?

@simonge simonge requested a review from wdconinc April 12, 2025 20:32
@wdconinc
Copy link
Contributor

I'll look later. You might have seen my PR too. No preference either way and likely close to identical.

@wdconinc wdconinc added this pull request to the merge queue Apr 12, 2025
Merged via the queue into main with commit e13d78b Apr 12, 2025
84 of 86 checks passed
@wdconinc wdconinc deleted the Restore-TaggerTrackerRecHits branch April 12, 2025 23:13
@veprbl veprbl added the backport v1.24 Backport into v1.24 label Apr 13, 2025
@epic-capybara
Copy link

Backport failed for v1.24, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin v1.24
git worktree add -d .worktree/backport-1792-to-v1.24 origin/v1.24
cd .worktree/backport-1792-to-v1.24
git switch --create backport-1792-to-v1.24
git cherry-pick -x e13d78ba0ddeb30c2e86c205c4fdd414d8ba144a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport v1.24 Backport into v1.24
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants