Skip to content

Conversation

@wdconinc
Copy link
Contributor

@wdconinc wdconinc commented Nov 25, 2025

Briefly, what does this PR introduce?

This PR removes llvm ~gold from the requirements since in spack v1.1.0 this leads to issues when we have an external llvm (without gold specification since not detected) and an internal llvm ~gold.

We have llvm ~gold since we run into issues with numba builds for tensorflow if we link with gold.

Ref: https://eicweb.phy.anl.gov/containers/eic_container/-/merge_requests/1158

Copilot AI review requested due to automatic review settings November 25, 2025 22:08
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.


💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Removed llvm package requirement for gold.
@wdconinc
Copy link
Contributor Author

This is probably not necessary, and was trying to address a symptom of a different problem (inability to have any ipo requirements on llvm and still use external llvm).

@wdconinc wdconinc closed this Dec 29, 2025
@wdconinc wdconinc deleted the llvm-gold branch December 29, 2025 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants