add 10x130 interpolated beamline to enable normal usage like other en… #839
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
veprbl
approved these changes
Mar 10, 2025
…y-account-for-B0-field
veprbl
deleted the
adjust-10x130-ep-magnet-settings-to-correctly-account-for-B0-field
branch
github-merge-queue bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Mar 12, 2025
### Briefly, what does this PR introduce? Updates the 10x130 RP matrix to match the new beamline settings: eic/epic#839 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ x] Other: updated to match magnet settings ### Please check if this PR fulfills the following: - [x ] Tests for the changes have been added - [x ] Documentation has been added / updated - [x ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? Yes, it will make the 10x130 RP reco correct for this energy setting with above magnet setting change. ### Does this PR change default behavior? Yes, see above. [RP_and_B0_pt_resolution_comparison_10_100_and_interpol_10_130_3_7_2025.pdf](https://github.com/user-attachments/files/19130938/RP_and_B0_pt_resolution_comparison_10_100_and_interpol_10_130_3_7_2025.pdf) [pt_squared_and_RP_hit_plot_comparison_10_100_and_interpol_10_130_3_7_2025.pdf](https://github.com/user-attachments/files/19130939/pt_squared_and_RP_hit_plot_comparison_10_100_and_interpol_10_130_3_7_2025.pdf) --------- Co-authored-by: Alexander Jentsch <[email protected]> Co-authored-by: Dmitry Kalinkin <[email protected]>
veprbl
pushed a commit
that referenced
this pull request
Mar 15, 2025
#839) …ergies ### Briefly, what does this PR introduce? This PR introduces a 10x130 lattice which has been calculated via interpolation between the three "core" beam energy settings, while still keeping the B0 constant. This will be paired with a similar PR for the RP matrices in EICrecon. This updated magnet setting file will allow for "normal" usage of the file, where the B0 and RP can be used simultaneously. ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ x] New feature (issue #__) - [ ] Documentation update - [ ] Other: __ ### Please check if this PR fulfills the following: - [ x] Tests for the changes have been added - [x] Documentation has been added / updated - [x ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? No, improves performance. ### Does this PR change default behavior? Yes, it changes the default 10x130 magnet settings to something which can be properly used.
github-actions bot
pushed a commit
to eic/EICrecon
that referenced
this pull request
Mar 15, 2025
### Briefly, what does this PR introduce? Updates the 10x130 RP matrix to match the new beamline settings: eic/epic#839 ### What kind of change does this PR introduce? - [ ] Bug fix (issue #__) - [ ] New feature (issue #__) - [ ] Documentation update - [ x] Other: updated to match magnet settings ### Please check if this PR fulfills the following: - [x ] Tests for the changes have been added - [x ] Documentation has been added / updated - [x ] Changes have been communicated to collaborators ### Does this PR introduce breaking changes? What changes might users need to make to their code? Yes, it will make the 10x130 RP reco correct for this energy setting with above magnet setting change. ### Does this PR change default behavior? Yes, see above. [RP_and_B0_pt_resolution_comparison_10_100_and_interpol_10_130_3_7_2025.pdf](https://github.com/user-attachments/files/19130938/RP_and_B0_pt_resolution_comparison_10_100_and_interpol_10_130_3_7_2025.pdf) [pt_squared_and_RP_hit_plot_comparison_10_100_and_interpol_10_130_3_7_2025.pdf](https://github.com/user-attachments/files/19130939/pt_squared_and_RP_hit_plot_comparison_10_100_and_interpol_10_130_3_7_2025.pdf) --------- Co-authored-by: Alexander Jentsch <[email protected]> Co-authored-by: Dmitry Kalinkin <[email protected]> (cherry picked from commit dba129a)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ergies
Briefly, what does this PR introduce?
This PR introduces a 10x130 lattice which has been calculated via interpolation between the three "core" beam energy settings, while still keeping the B0 constant. This will be paired with a similar PR for the RP matrices in EICrecon.
This updated magnet setting file will allow for "normal" usage of the file, where the B0 and RP can be used simultaneously.
What kind of change does this PR introduce?
Please check if this PR fulfills the following:
Does this PR introduce breaking changes? What changes might users need to make to their code?
No, improves performance.
Does this PR change default behavior?
Yes, it changes the default 10x130 magnet settings to something which can be properly used.