Pass opentelemetry environment variables to v1alpha ETOS #402
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Applicable Issues
Found no issue for this specifically, but we are dependent on eiffel-community/etos-api#112 #401 and eiffel-community/etos-environment-provider#125
Description of the Change
The Suite Runner job will get its environment variables automatically from the deployed ETOS cluster whereas for the environment requests we check if we have a cluster to fetch and get it from there when possible.
I also make sure that we pass in the traceparents that can be set in the annotations field of our testruns and environmentrequests so that the opentelemetry trace graph is complete.
This change requires an update of the ETOS API as well as the environment provider to be considered complete.
Alternate Designs
I thought about using the spec for this, but I don't really like that because I don't feel that this is a part of the reconciliation of a testrun or environment. The annotation felt a bit more correct to me.
Possible Drawbacks
Nothing that I could think of right now. I guess this can be considered a bit too complex a solution considering it should just be passing of environment variables. I do believe we should look at this in the future so that it becomes a bit more simple.
I think that future is when the controller environment is the default way of running ETOS (i.e. ETOS v1 is released) because then we can start removing a lot of code in the separate services making it easier for us to streamline this.
Sign-off
Developer's Certificate of Origin 1.1
By making a contribution to this project, I certify that:
(a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or
(b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or
(c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.
(d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Signed-off-by: Tobias Persson [email protected]