Skip to content

Annotate some java.util.concurrent collections. #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 4, 2022
Merged

Annotate some java.util.concurrent collections. #16

merged 1 commit into from
May 4, 2022

Conversation

cpovirk
Copy link
Contributor

@cpovirk cpovirk commented May 4, 2022

Split off from #9, which also contains
some changes whose usefulness is unclear.

@cpovirk
Annotate some java.util.concurrent collections.
5f1a06f 
Split off from eisop#9, which also contains
some changes whose usefulness is unclear.
@cpovirk cpovirk mentioned this pull request May 4, 2022
Open
wmdietl
wmdietl approved these changes May 4, 2022
View reviewed changes
Copy link
Member

@wmdietl wmdietl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All this looks good. You didn't move over the removeAll / retainAll changes from #9 , which I think we had also agreed on. I'll merge this, you could open a separate PR for those changes.

@wmdietl wmdietl merged commit 1f8fbc8 into eisop:master May 4, 2022
@cpovirk cpovirk mentioned this pull request Aug 29, 2022
Closed
cpovirk added a commit to cpovirk/jdk that referenced this pull request Sep 7, 2023
@cpovirk
Omit @NonNull from merge in maps that reject null values. (eisop#16)
2126e8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmdietl wmdietl wmdietl approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cpovirk @wmdietl