chore(deps): bump changesets/action from 1.9.0 to 2.1.2 - #67
dependabot[bot] wants to merge 1 commit into
Conversation
65a5421 to
8b9d96e
Compare
|
Holding this one, and it is not a judgement about the version. v2 of this action requires Changesets CLI v3, and this repository is on Merging the SHA alone would also break
And the "Say what happened" step reads There is one more that is easy to miss. Published-package detection no longer parses stdout: it uses a shared file via a The order this has to happen in
Step 3 is the reason this is worth doing deliberately rather than quickly: the publish job is the one place where getting it wrong is not repealable. Leaving this open as the record. |
Supersedes #68 and #69, which are both correct and both incomplete: Dependabot generated them before pages.yml existed, so between them they update 6 of the 7 checkout pins and 5 of the 6 setup-node pins. Leaving the Pages workflow a major behind means two sets of pins in one repository until the robot notices again. Both majors were read rather than assumed safe: - checkout v7 blocks checking out a fork PR under pull_request_target and workflow_run. Neither trigger appears in any workflow here. - checkout v6 moved credential persistence to a separate file. Nothing here reads .git/config for a token. - setup-node v6 disabled AUTOMATIC caching for pnpm and yarn. It did not remove the feature, and every job here passes `cache: pnpm` explicitly, which is the supported form. This is the one that looked like a problem and is not. - setup-node v7 removed a dummy NODE_AUTH_TOKEN export. Publishing authenticates with an OIDC token from a trusted publisher, so there is nothing to remove. All three SHAs in the robot's pull requests were checked against their tags through the API before being used, because a pin whose comment lies is worse than no pin. That is not hypothetical here: a fabricated version comment shipped once already.⚠️ release.yml is changed but cannot be exercised by this pull request. It triggers on push to main only, so its two checkout steps and its setup-node step first run after this merges. The risk is small, since the same versions are proven by the other three workflows on this branch, but it is not zero and it is worth knowing which line of the change CI did not cover. changesets/action is deliberately not here. See #67 and #89. Closes #89 Co-authored-by: Ahmed Elmalt <6933715+eknowledger@users.noreply.github.com>
Bumps [changesets/action](https://github.com/changesets/action) from 1.9.0 to 2.1.2. - [Release notes](https://github.com/changesets/action/releases) - [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md) - [Commits](changesets/action@a45c4d5...ae32849) --- updated-dependencies: - dependency-name: changesets/action dependency-version: 2.1.2 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
8b9d96e to
64b0d2b
Compare
Bumps changesets/action from 1.9.0 to 2.1.2.
Release notes
Sourced from changesets/action's releases.
... (truncated)
Changelog
Sourced from changesets/action's changelog.
... (truncated)
Commits
ae32849v2.1.20138f45Version Packages (#726)8833883Handle error when pushing git tags with the git CLI (#735)e08fde7Improve log messages (#730)371fd77Bump human-id in the production-dependencies group across 1 directory (#732)85efcafBump actions/checkout in the github-actions group across 1 directory (#734)5bb9d5cBump the development-dependencies group across 1 directory with 7 updates (#733)ca85897Always prepare branch for version (#729)36f529fFix root action double error logs (#724)d7669c8Version Packages (#722)