Skip to content

Sleep before collecting metrics #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Sleep before collecting metrics #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions cmd/apmbench/run.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -91,13 +91,6 @@ func Run(
return fmt.Errorf("benchmark %q failed", name)
}
fmt.Printf("%-*s\t%s\n", maxLen, name, result.benchResult)
// Sleep to allow any remaining data to be consumed by the pipelines
// so that they don't pollute the result of the next benchmark run.
//
// TODO (lahsivjar): Make this deterministic by introducing cleanup
// metrics. We can watch the cleanup metrics to reach to a specified
// threshold and then run the next benchmark.
time.Sleep(time.Minute)
}
}
}
Expand Down Expand Up @@ -126,6 +119,15 @@ func runOne(

result.skipped = b.Skipped()
result.failed = b.Failed()

// Sleep to allow any remaining data to be consumed by the pipelines
// so that they don't pollute the result of the next benchmark run.
//
// TODO (lahsivjar): Make this deterministic by introducing cleanup
// metrics. We can watch the cleanup metrics to reach to a specified
// threshold and then run the next benchmark.
time.Sleep(time.Minute)

extraMetrics(b)
})
return result
Expand Down