Skip to content

[8.18] (backport #16788) ci: use manual caching with actions/cache #16790

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented May 5, 2025

Motivation/summary

use os agnostic cache key
only cache pkg mod cache

Checklist

For functional changes, consider:

  • Is it observable through the addition of either logging or metrics?
  • Is its use being published in telemetry to enable product improvement?
  • Have system tests been added to avoid regression?

How to test these changes

Related issues


This is an automatic backport of pull request #16788 done by [Mergify](https://mergify.com).

* ci: use manual caching with actions/cache

use os agnostic cache key
only cache pkg mod cache

* ci: enable enableCrossOsArchive

by default cache won't be shared across os

enable it so we can reuse the go module cache

(cherry picked from commit bac9fec)

# Conflicts:
#	.github/workflows/ci.yml
@mergify mergify bot requested a review from a team as a code owner May 5, 2025 05:58
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels May 5, 2025
Copy link
Contributor Author

mergify bot commented May 5, 2025

Cherry-pick of bac9fec has failed:

On branch mergify/bp/8.18/pr-16788
Your branch is up to date with 'origin/8.18'.

You are currently cherry-picking commit bac9fec6.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .github/workflows/ci.yml

no changes added to commit (use "git add" and/or "git commit -a")

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

Copy link
Contributor Author

mergify bot commented May 5, 2025

This pull request has not been merged yet. Could you please review and merge it @kruskall? 🙏

@kruskall kruskall removed the conflicts There is a conflict in the backported pull request label May 5, 2025
@mergify mergify bot merged commit 91e0bc4 into 8.18 May 5, 2025
15 checks passed
@mergify mergify bot deleted the mergify/bp/8.18/pr-16788 branch May 5, 2025 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant