Add TBS examples to explain policy naunces #1239
Open
+45
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carsonip
reviewed
Apr 25, 2025
|
also looping in @colleenmcginnis for 👀 on language and style |
carsonip
approved these changes
Apr 29, 2025
There was a problem hiding this comment.
nit: the fallback sampling rate is higher than the more specific policies, which is a bit unusual, but not incorrect, as users usually like to sample more for specific ones, and sample less otherwise.
lgtm from correctness PoV. Would like 👀 from @colleenmcginnis for style
colleenmcginnis
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes elastic/apm-server#16253
Add two examples to TBS policy configurations:
servicedefinitions.traceandservicedefinitions.