-
Notifications
You must be signed in to change notification settings - Fork 66
Updates MITRE docs to currently used version v16.1
#1292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
dplumlee
wants to merge
1
commit into
main
Choose a base branch
from
mitre-16.1-update
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - thanks for making these changes! Also recommend merging this closer to the GA date for 9.0.1.
nastasha-solomon
approved these changes
Apr 28, 2025
7 tasks
dplumlee
added a commit
to elastic/kibana
that referenced
this pull request
Apr 28, 2025
## Summary Addresses: #166152 for `8.18.1` and #203370 Updates MITRE ATT&CK mappings to `v16.1`. Last update was to `v15.1` in #183463. To update, I modified https://github.com/elastic/kibana/blob/df55627b2d695b8721928cb453db31e2b5cb73a4/x-pack/solutions/security/plugins/security_solution/scripts/extract_tactics_techniques_mitre.js#L22 to point to the `ATT&CK-v16.1` tag. Then ran `yarn extract-mitre-attacks` from the root `security_solution` plugin directory, and then `node scripts/i18n_check.js --fix` from Kibana root to regen the i18n files. ## Acceptance Criteria - [x] User can map and use new MITRE techniques in Security Solution - [ ] The user-facing documentation is updated with the new version - [ ] [MITRE ATT&CK® coverage](https://www.elastic.co/guide/en/security/master/rules-coverage.html) page - [ ] elastic/security-docs#6797 - [ ] elastic/docs-content#1292 ## Test Criteria This PR also updates our cypress tests which run with real MITRE data generated by the same `extract_tactics_techniques_mitre` script. Our tests would often break when the data was updated to a new version because the UI elements being tested would cover each other leading to flakiness or outright test failure. In order to ensure a more streamline update process the tests should no longer break because of this flakiness and only when there's a more serious issue. - [x] Verify that new techniques (see the changelog link above) are available for mapping on the Rule Creation page under "Advanced settings" - [x] Verify that new techniques are available on the MITRE ATT&CK coverage page --------- Co-authored-by: Maxim Palenov <[email protected]> Co-authored-by: Elastic Machine <[email protected]>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 28, 2025
) ## Summary Addresses: elastic#166152 for `8.18.1` and elastic#203370 Updates MITRE ATT&CK mappings to `v16.1`. Last update was to `v15.1` in elastic#183463. To update, I modified https://github.com/elastic/kibana/blob/df55627b2d695b8721928cb453db31e2b5cb73a4/x-pack/solutions/security/plugins/security_solution/scripts/extract_tactics_techniques_mitre.js#L22 to point to the `ATT&CK-v16.1` tag. Then ran `yarn extract-mitre-attacks` from the root `security_solution` plugin directory, and then `node scripts/i18n_check.js --fix` from Kibana root to regen the i18n files. ## Acceptance Criteria - [x] User can map and use new MITRE techniques in Security Solution - [ ] The user-facing documentation is updated with the new version - [ ] [MITRE ATT&CK® coverage](https://www.elastic.co/guide/en/security/master/rules-coverage.html) page - [ ] elastic/security-docs#6797 - [ ] elastic/docs-content#1292 ## Test Criteria This PR also updates our cypress tests which run with real MITRE data generated by the same `extract_tactics_techniques_mitre` script. Our tests would often break when the data was updated to a new version because the UI elements being tested would cover each other leading to flakiness or outright test failure. In order to ensure a more streamline update process the tests should no longer break because of this flakiness and only when there's a more serious issue. - [x] Verify that new techniques (see the changelog link above) are available for mapping on the Rule Creation page under "Advanced settings" - [x] Verify that new techniques are available on the MITRE ATT&CK coverage page --------- Co-authored-by: Maxim Palenov <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 203cfc6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 28, 2025
) ## Summary Addresses: elastic#166152 for `8.18.1` and elastic#203370 Updates MITRE ATT&CK mappings to `v16.1`. Last update was to `v15.1` in elastic#183463. To update, I modified https://github.com/elastic/kibana/blob/df55627b2d695b8721928cb453db31e2b5cb73a4/x-pack/solutions/security/plugins/security_solution/scripts/extract_tactics_techniques_mitre.js#L22 to point to the `ATT&CK-v16.1` tag. Then ran `yarn extract-mitre-attacks` from the root `security_solution` plugin directory, and then `node scripts/i18n_check.js --fix` from Kibana root to regen the i18n files. ## Acceptance Criteria - [x] User can map and use new MITRE techniques in Security Solution - [ ] The user-facing documentation is updated with the new version - [ ] [MITRE ATT&CK® coverage](https://www.elastic.co/guide/en/security/master/rules-coverage.html) page - [ ] elastic/security-docs#6797 - [ ] elastic/docs-content#1292 ## Test Criteria This PR also updates our cypress tests which run with real MITRE data generated by the same `extract_tactics_techniques_mitre` script. Our tests would often break when the data was updated to a new version because the UI elements being tested would cover each other leading to flakiness or outright test failure. In order to ensure a more streamline update process the tests should no longer break because of this flakiness and only when there's a more serious issue. - [x] Verify that new techniques (see the changelog link above) are available for mapping on the Rule Creation page under "Advanced settings" - [x] Verify that new techniques are available on the MITRE ATT&CK coverage page --------- Co-authored-by: Maxim Palenov <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 203cfc6)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Apr 28, 2025
) ## Summary Addresses: elastic#166152 for `8.18.1` and elastic#203370 Updates MITRE ATT&CK mappings to `v16.1`. Last update was to `v15.1` in elastic#183463. To update, I modified https://github.com/elastic/kibana/blob/df55627b2d695b8721928cb453db31e2b5cb73a4/x-pack/solutions/security/plugins/security_solution/scripts/extract_tactics_techniques_mitre.js#L22 to point to the `ATT&CK-v16.1` tag. Then ran `yarn extract-mitre-attacks` from the root `security_solution` plugin directory, and then `node scripts/i18n_check.js --fix` from Kibana root to regen the i18n files. ## Acceptance Criteria - [x] User can map and use new MITRE techniques in Security Solution - [ ] The user-facing documentation is updated with the new version - [ ] [MITRE ATT&CK® coverage](https://www.elastic.co/guide/en/security/master/rules-coverage.html) page - [ ] elastic/security-docs#6797 - [ ] elastic/docs-content#1292 ## Test Criteria This PR also updates our cypress tests which run with real MITRE data generated by the same `extract_tactics_techniques_mitre` script. Our tests would often break when the data was updated to a new version because the UI elements being tested would cover each other leading to flakiness or outright test failure. In order to ensure a more streamline update process the tests should no longer break because of this flakiness and only when there's a more serious issue. - [x] Verify that new techniques (see the changelog link above) are available for mapping on the Rule Creation page under "Advanced settings" - [x] Verify that new techniques are available on the MITRE ATT&CK coverage page --------- Co-authored-by: Maxim Palenov <[email protected]> Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 203cfc6)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Related to: elastic/kibana#215026
Updates MITRE related documentation to currently used version
16.1