Update 8.x to 8.19

[bmorelli25]

Updates 8.x to 8.19 in the legacy docs.

[github-actions]

A documentation preview will be available soon.

• 🔨 Buildkite builds
• 📚 HTML diff
• 📙 Preview page

Request a new doc build by commenting

• Rebuild this PR: run docs-build
• Rebuild this PR and all Elastic docs: run docs-build rebuild

_{run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.}

_{If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.}

[bmorelli25]

This is failing on bad 8.x to 8.19 links which makes me think there's something goofy somewhere that I forgot about...

[bmorelli25]

Sure enough. Sometimes saying it out loud is enough.

[bmorelli25]

Nice. Down to a hanful:

INFO:build_docs:Bad cross-document links:
--
  | INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/reference/8.18/es-connectors-tutorial-api.html contains broken links to:
  | INFO:build_docs:   - en/elasticsearch/reference/8.x/create-connector-api.html
  | INFO:build_docs:   - en/kibana/8.x/console-kibana.html
  | INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/reference/8.19/es-connectors-tutorial-api.html contains broken links to:
  | INFO:build_docs:   - en/elasticsearch/reference/8.x/create-connector-api.html
  | INFO:build_docs:   - en/kibana/8.x/console-kibana.html
  | INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/elasticsearch/reference/current/es-connectors-tutorial-api.html contains broken links to:
  | INFO:build_docs:   - en/elasticsearch/reference/8.x/create-connector-api.html
  | INFO:build_docs:   - en/kibana/8.x/console-kibana.html

[lcawl]

This work-around is no longer necessary anymore:

docs/build_docs.pl

Line 416 in 48c99a5

if ($version eq "8.x") {

... I guess it isn't hurting anything if it lingers.

I double-checked that we weren't also doing something like that in the Kibana doc link service, but https://github.com/elastic/kibana/blob/8.19/src/platform/packages/shared/kbn-doc-links/src/get_doc_meta.ts LGTM (just means the UI has broken links until we get the 8.19 docs live).

[bmorelli25]

Thanks, Lisa! Removed in 2d73726

[karenzone]

LGTM