Skip to content

RFC 0013 Network Headers - stage 1 #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

leehinman
Copy link
Contributor

  • switch to field set that can be nested under source and destination

@ebeahan ebeahan added the RFC label Jul 12, 2021
@ebeahan
Copy link
Member

ebeahan commented Jul 15, 2021

Adding this entry listing the stage 1 criteria to help us track outstanding items.

Stage 1 Criteria:

  • Opened pull request for this proposal revising the existing strawperson
  • Identified "sponsor" at Elastic who will participate in RFC process and take ownership of the change after the process completes
  • Outlined initial field definitions
  • High-level description of examples of usage
  • High-level description of example sources of data
  • Identified potential concerns and implementation challenges/complexity
  • Subject matter experts identified and weighed in on the high level utility of these changes in the pull request
  • ECS team weighed in on appropriateness of these changes in the pull request

@ebeahan
Copy link
Member

ebeahan commented Jul 15, 2021

@leehinman When you have some time to come back to this, would you be able to create field definitions of these additions? These definitions can be organized into a directory named 0013 after the RFC like we've done elsewhere.

I think accounting for capturing the different headers for directional flows is a good improvement. I worry about using header as the field set name for all flag data because values like .ip and .port are also in the connection headers, and I could see it becoming confusing quickly.

@ebeahan ebeahan changed the title RFC 13 address stage 0 feedback RFC 13 - stage 1 Nov 10, 2021
@legoguy1000
Copy link
Contributor

legoguy1000 commented Nov 10, 2021

I'll add my comment that I think that the header fields should stay under network as all the tools that i've seen supply that data, don't distinguish. For all traffic the header will always be from the source. 🤷‍♂️

@ebeahan ebeahan changed the title RFC 13 - stage 1 RFC 0013 Network Headers - stage 1 Nov 11, 2021
@legoguy1000
Copy link
Contributor

@any updates on this??

@github-actions
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Apr 14, 2022
@legoguy1000
Copy link
Contributor

un-stale :)

@github-actions github-actions bot removed the stale Stale issues and pull requests label Apr 15, 2022
@rwaight
Copy link

rwaight commented Apr 28, 2022

If the current plan is to put network as a field set under source and destination, then it should also be placed under client and server as this is relevant to data coming from Zeek. Otherwise, I agree with the header fields staying under network. as mentioned in #1508 (comment).

@jamiehynds
Copy link
Contributor

@leehinman @dainperkins this RFC has been stale for some time, but there's certainly still demand. Do you think you'll have time to advance the RFC over the coming weeks? (No problem whatsoever if not).

@leehinman
Copy link
Contributor Author

I don't think I will have the time :-(

@github-actions
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Jul 17, 2022
@legoguy1000
Copy link
Contributor

don't be stale :)

@github-actions github-actions bot removed the stale Stale issues and pull requests label Jul 23, 2022
@github-actions
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Sep 21, 2022
@rwaight
Copy link

rwaight commented Sep 21, 2022

  • Identified "sponsor" at Elastic who will participate in RFC process and take ownership of the change after the process completes

If this still needs an internal "sponsor" at Elastic, I am willing to sponsor this RFC. As mentioned in #1508 (comment). I still agree that the header fields should stay under network. as mentioned in #1508 (comment).

If we have an internal sponsor, what are the next steps to move this forward, @ebeahan and @leehinman ?

@rwaight rwaight removed the stale Stale issues and pull requests label Sep 21, 2022
@github-actions
Copy link

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Nov 21, 2022
@legoguy1000
Copy link
Contributor

Bump

@github-actions github-actions bot removed the stale Stale issues and pull requests label Feb 1, 2024
Copy link

github-actions bot commented Apr 1, 2024

This PR is stale because it has been open for 60 days with no activity.

@github-actions github-actions bot added the stale Stale issues and pull requests label Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC stale Stale issues and pull requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants