-
Notifications
You must be signed in to change notification settings - Fork 178
add k8s_leader_elector otel extension #9065
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
This pull request does not have a backport label. Could you fix it @rogercoll? 🙏
|
@rogercoll , thinking out loud, are you sure we should add new components to already released versions (backport labels)? 🙂 |
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
Not a strong opinion, the idea for backporting to Would you suggest targeting new major and minor versions only? |
What you say makes sense to me but I am not sure it is aligned with the "accepted changes for already released versions" policy we might have. I trust though that one of, if not all, of @ebeahan @pierrehilbert @AlexanderWert @cmacknz do know 🙂 |
EDIT: after re-reading and discussed with @pkoutsovasilis please forget my previous comment. |
|
💚 Build Succeeded
cc @rogercoll |
@rogercoll the extension you're adding here depends on the otel core framework 0.129.0, but we have earlier versions in other branches and don't plan to upgrade them. Will that work? |
Good point, and no, it does not compile the agent correctly due to some APIs dependencies misalignment. Changed the target backports to the branches updated to |
What does this PR do?
Adds the K8s leader elector Otel Extension: https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/k8sleaderelector
Why is it important?
Kube-stack Helm Chart is going to rely on this extension for cluster-wide events and metrics: open-telemetry/opentelemetry-helm-charts#1735
Checklist
./changelog/fragments
using the changelog toolDisruptive User Impact
How to test this PR locally
Related issues
Questions to ask yourself