Skip to content

Conversation

nikolay-voskresenskiy-db
Copy link

@nikolay-voskresenskiy-db nikolay-voskresenskiy-db commented Oct 8, 2025

Thank you for submitting a pull request!

Please make sure you have signed our Contributor License Agreement (CLA).
We are not asking you to assign copyright to us, but to give us the right to distribute your code without restriction. We ask this of all contributors in order to assure our users of the origin and continuing existence of the code.
You only need to sign the CLA once.

Merge in PDS-GTB/elasticsearch-hadoop from spark-35 to db-feature/spark-35

* commit 'fc4f33b6c3d609f18b820b25cc1435a2c4c5ead8':
  Spark 3.5 support
Copy link

❌ Author of the following commits did not sign a Contributor Agreement:
fc4f33b, f667aef

Please, read and sign the above mentioned agreement if you want to contribute to this project

@nikolay-voskresenskiy-db
Copy link
Author

A few notes on the implementation:

  1. The actual change that makes the runtime code compatible with spark 3.5.x is a single line in EsStreamQueryWriter.scala. There is no functional change, only a signature change inside internal spark API, The rest of the changes are related to building and testing:
  2. We made the artifact for 3.5 into a separate build variant to prove out that the same code is compatible with both 3.4 and 3.5 via the test suite. This has a negative impact of prolonging build time, so the variant for 3.4 could be removed in future and 3.5 left as the primary variant
  3. StreamingQueryLifecycleListener helper class in the tests now needs two versions because spark 3.5 splits out the stream idleness notification logic into a separate method
  4. 3.5 has a slight change in dependencies since spark gets a separate spark-sql-api module
  5. Had to make a few fixes to the build scaffolding to correctly handle 4 build variants instead of 2

@nikolay-voskresenskiy-db nikolay-voskresenskiy-db changed the title Db contrib/spark 35 Spark 3.5 support Oct 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant