Skip to content

Conversation

@theletterf
Copy link
Contributor

@theletterf theletterf commented Oct 14, 2025

@prodsecmachine
Copy link

prodsecmachine commented Oct 14, 2025

Snyk checks have passed. No issues have been found so far.

Status Scanner Critical High Medium Low Total (0)
Licenses 0 0 0 0 0 issues
Open Source Security 0 0 0 0 0 issues

💻 Catch issues earlier using the plugins for VS Code, JetBrains IDEs, Visual Studio, and Eclipse.

@github-actions
Copy link
Contributor

github-actions bot commented Oct 14, 2025

🔍 Preview links for changed docs

@theletterf theletterf enabled auto-merge (squash) October 14, 2025 09:00
david-luna
david-luna previously approved these changes Oct 15, 2025
Copy link
Member

@david-luna david-luna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@theletterf
Copy link
Contributor Author

@david-luna Tests are stuck for some reason. Could you merge manually?

@marciw marciw self-requested a review October 15, 2025 12:58
@marciw
Copy link
Contributor

marciw commented Oct 15, 2025

@theletterf I'd also suggest getting a review from @JoshMock

@marciw marciw requested a review from JoshMock October 15, 2025 13:12
@theletterf
Copy link
Contributor Author

@marciw Thanks, suggestions applied!

@JoshMock Could you have a look? It's a small change with some drive-by edits.

@marciw marciw requested a review from margaretjgu October 16, 2025 13:44
@margaretjgu
Copy link
Member

Hey @marciw & @theletterf, the actions are stuck because the workflow uses path filtering to skip tests for documentation-only changes. But when they're skipped, GitHub branch protection never receives a status report...leaving them stuck waiting. I'll make this improvement in a separate PR.

Workaround - Added a trivial change to package.json (blank line) or src/ to trigger the tests.

@JoshMock JoshMock disabled auto-merge October 20, 2025 16:23
@JoshMock JoshMock merged commit 91a3653 into main Oct 20, 2025
17 checks passed
@JoshMock JoshMock deleted the theletterf-patch-1 branch October 20, 2025 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants