Fix optional array keys in PHPDocs #1426
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work, hopefully we can get this merged soon so we can start on correcting all the invalid types. Merging this will also address most of the issues reported by PHPStan 2 |
AJenbo
approved these changes
Feb 20, 2025
This was referenced Feb 22, 2025
|
@ezimuel Could you please approve the workflow? |
|
@ezimuel could you please let me know what's needed to merge and tag this? It would be great to silence the PHPStan errors |
|
@AnnaNtagiou sorry for my late reply. I'm fixing the PHPStan issues in the code generator. We cannot fix it here. I'll update you when ready. I'm working on it. |
|
@ezimuel where can we find the code generator so we can help resolve some of the data type issues? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes #1424 in
IndicesandClientEndpointsTrait