-
Notifications
You must be signed in to change notification settings - Fork 983
sync the Git page and the docs page for PHP client overview #1472
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sync the Git page and the docs page for PHP client overview #1472
Conversation
add serverless info add subs to docsets
🔍 Preview links for changed docs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this PR, it looks awesome. I left one small note that contains two useful external links (in elastic.co and search labs) that maybe can be added in the documentation.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks! A couple of suggestions but approving. 👍
Co-authored-by: Marci W <[email protected]>
Linked to elastic/docs-content#2617
Cleanup the PHP client overview page
Add info for Serverless as mentioned in the Git page
add subs in docsets