-
Notifications
You must be signed in to change notification settings - Fork 105
[ML] Add SageMaker #4940
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
[ML] Add SageMaker #4940
Conversation
Create put request types, objects, and examples for SageMaker. Verified with `make validate api=inference.put`.
/** | ||
* Service Settings specific to the Elastic API for the Amazon SageMaker service. | ||
*/ | ||
export class AmazonSageMakerElasticServiceSettings extends AmazonSageMakerServiceSettings { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me know if I should delete this and roll it into the parent class - I don't see a lot of inheritance going on (and that's maybe a good thing) but it might look weird for TaskSettings because elastic
can handle any input key/value pair
Following you can find the validation changes against the target branch for the API.
You can validate this API yourself by using the |
endpoint_name: string | ||
/** | ||
* The API format to use when calling SageMaker. | ||
* This will structure the payload when invoking the SageMaker endpoint. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm did you mean: This will be the structure of the payload...
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe? I don't know what I mean lol
I'm trying to say that we'll convert from the elastic payload that is sent during the inference request to the selected api
and send that as the payload
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I left some nits, please take or leave them. We place the examples in an example
> request
folder so that the generator can find them. Would you mind putting the request
folder into an example
folder, please?
Co-authored-by: Jonathan Buttner <[email protected]> Co-authored-by: István Zoltán Szabó <[email protected]>
@prwhelan Thank you for providing the docs and doing the update! |
Sorry! I missed this comment. Thank you for reiterating |
Create put request types, objects, and examples for SageMaker. Verified with
make validate api=inference.put
.