Skip to content

[ML] Add SageMaker #4940

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

[ML] Add SageMaker #4940

wants to merge 7 commits into from

Conversation

prwhelan
Copy link
Member

Create put request types, objects, and examples for SageMaker. Verified with make validate api=inference.put.

Create put request types, objects, and examples for SageMaker.
Verified with `make validate api=inference.put`.
/**
* Service Settings specific to the Elastic API for the Amazon SageMaker service.
*/
export class AmazonSageMakerElasticServiceSettings extends AmazonSageMakerServiceSettings {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let me know if I should delete this and roll it into the parent class - I don't see a lot of inheritance going on (and that's maybe a good thing) but it might look weird for TaskSettings because elastic can handle any input key/value pair

Copy link
Contributor

github-actions bot commented Jul 16, 2025

Following you can find the validation changes against the target branch for the API.

API Status Request Response
inference.put_amazonsagemaker 🟠 → ⚪ Missing type → Missing test Missing type → Missing test

You can validate this API yourself by using the make validate target.

@prwhelan prwhelan marked this pull request as ready for review July 22, 2025 13:28
endpoint_name: string
/**
* The API format to use when calling SageMaker.
* This will structure the payload when invoking the SageMaker endpoint.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm did you mean: This will be the structure of the payload...?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe? I don't know what I mean lol

I'm trying to say that we'll convert from the elastic payload that is sent during the inference request to the selected api and send that as the payload

Copy link
Contributor

@szabosteve szabosteve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left some nits, please take or leave them. We place the examples in an example > request folder so that the generator can find them. Would you mind putting the request folder into an example folder, please?

@szabosteve
Copy link
Contributor

@prwhelan Thank you for providing the docs and doing the update!
Wanted to mention that we place the examples in an example > request folder so that the generator can find them. Would you mind putting the request folder into an example folder, please?

@prwhelan
Copy link
Member Author

@prwhelan Thank you for providing the docs and doing the update! Wanted to mention that we place the examples in an example > request folder so that the generator can find them. Would you mind putting the request folder into an example folder, please?

Sorry! I missed this comment. Thank you for reiterating

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants