-
Notifications
You must be signed in to change notification settings - Fork 25k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Lucene 10.1.0 #119308
Upgrade to Lucene 10.1.0 #119308
Conversation
This was restored due to a bad merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM thanks (only one small thing in the buildkite pipelines that I think should get reverted, although it should not take effect)
...per-extras/src/main/java/org/elasticsearch/index/mapper/extras/SourceConfirmedTextQuery.java
Show resolved
Hide resolved
@ChrisHegarty I'm working on apache/lucene#14131, but in order to test it with Elasticsearch, I needed to test with Elasticsearch that uses Lucene 10. Hence, I'm looking at this branch. However, the work in apache/lucene#14131 integrates cuvs-java that uses Project Panama's features in JDK 22. However, Elasticsearch (as of this branch) still is on JDK21. Hence, trying to "gradlew compileJava" results in the following:
(the patch is https://termbin.com/v0co on top of this branch, along with the Lucene PR for cuVS being available from a local maven snapshot based on 10.2). Any ideas or thoughts, please? Is there a plan (or will there be) to raise minimum JDK level to 22? |
There is certainly some complications here, but we can resolve them. Elasticsearch compiles with a minimum of JDK 21, but runs with the latest JDK, currently 23. We mostly do something similar with Lucene. I need to look a bit more at how this is all supposed to work in Lucene first, then I'll see how we can get this working with ES. |
I'm trying to get a branch working with it: https://github.com/SearchScale/elasticsearch/tree/cuvs-integration |
Linking this test PR that we need before merging the Lucene 10.1.0 upgrade - #121104 |
Nice work @ChrisHegarty 👏 |
There are no plans to bump the minimum Java version at this time. The soonest we would do this would be with the release of Java 25, as our general policy is for minimum runtime version to be LTS versions. |
This commit upgrades to Lucene 10.1.0.