Fix tests involving getBestDowngradeVersion #127646
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
prdoyle
added
>test
|
Pinging @elastic/es-core-infra (Team:Core/Infra) |
mosche
approved these changes
May 5, 2025
ywangd
pushed a commit
to ywangd/elasticsearch
that referenced
this pull request
May 9, 2025
* Fix tests involving getBestDowngradeVersion * [CI] Auto commit changes from spotless * Typo in assume message --------- Co-authored-by: elasticsearchmachine <[email protected]>
jfreden
pushed a commit
to jfreden/elasticsearch
that referenced
this pull request
May 12, 2025
* Fix tests involving getBestDowngradeVersion * [CI] Auto commit changes from spotless * Typo in assume message --------- Co-authored-by: elasticsearchmachine <[email protected]>
mosche
added
v9.0.4
auto-backport
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
mosche
pushed a commit
to mosche/elasticsearch
that referenced
this pull request
Jul 4, 2025
* Fix tests involving getBestDowngradeVersion * [CI] Auto commit changes from spotless * Typo in assume message --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 64568ee) # Conflicts: # muted-tests.yml
elasticsearchmachine
pushed a commit
that referenced
this pull request
Jul 4, 2025
* Fix tests involving getBestDowngradeVersion * [CI] Auto commit changes from spotless * Typo in assume message --------- Co-authored-by: elasticsearchmachine <[email protected]> (cherry picked from commit 64568ee) # Conflicts: # muted-tests.yml Co-authored-by: Patrick Doyle <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the behaviour of
getBestDowngradeVersionwas defined in terms of major and minor versions, but this broke as soon as we moved to 9.1.The proper behaviour is "downgrade back to
previousVersionunless that's so old it's incompatible with the current version, in which case downgrade tominimumCompatibilityVersion". I've changed the unit tests to reflect this, and updated the javadocs.Fixes #124388.
Fixes #121316.