Add ElasticsearchIndexDeletionPolicy and EngineConfig policy wrapper #130442
Conversation
tlrx
added
>non-issue
:Distributed Indexing/Engine
elasticsearchmachine
added
the
serverless-linked
server/src/main/java/org/elasticsearch/index/engine/ElasticsearchIndexDeletionPolicy.java
Outdated
Show resolved
Hide resolved
|
|
||
| public abstract boolean hasUnreferencedCommits(); | ||
|
|
||
| public interface CommitsListener { |
There was a problem hiding this comment.
I was thinking about getting rid of this interface since we don't use it anymore, wdyt @kingherc? we can do in a follow-up once all the pieces are in place.
There was a problem hiding this comment.
Hi @fcofdez . Yes I believe it can be removed.
Separately, we were discussing whether IndexModule#setIndexCommitListener() could be removed in this thread with @tlrx , feel free to read to see as well. I had a question whether someone, e.g., externally, like a plugin writer user, might have been using it, but we think no. So that may also be considered for removal. However, maybe an optional follow-up.
elasticsearchmachine
added
the
Team:Distributed Indexing
|
Pinging @elastic/es-distributed-indexing (Team:Distributed Indexing) |
|
|
||
| public abstract boolean hasUnreferencedCommits(); | ||
|
|
||
| public interface CommitsListener { |
There was a problem hiding this comment.
Hi @fcofdez . Yes I believe it can be removed.
Separately, we were discussing whether IndexModule#setIndexCommitListener() could be removed in this thread with @tlrx , feel free to read to see as well. I had a question whether someone, e.g., externally, like a plugin writer user, might have been using it, but we think no. So that may also be considered for removal. However, maybe an optional follow-up.
| @@ -187,7 +180,7 @@ private void deleteCommit(IndexCommit commit) throws IOException { | |||
| assert commit.isDeleted() == false : "Index commit [" + commitDescription(commit) + "] is deleted twice"; | |||
| logger.debug("Delete index commit [{}]", commitDescription(commit)); | |||
| commit.delete(); | |||
| assert commit.isDeleted() : "Deletion commit [" + commitDescription(commit) + "] was suppressed"; | |||
| // assert commit.isDeleted() : "Deletion commit [" + commitDescription(commit) + "] was suppressed"; | |||
There was a problem hiding this comment.
nit Reminder to remove or adjust (maybe leave the assertion in stateful)
This change adds a new abstract class ElasticsearchIndexDeletionPolicy that allows using different policy implementations for InternalEngine.
It also adds an index deletion policy wrapper to the EngineConfig to allow wrapping the default CombinedDeletionPolicy by inheritors of InternalEngine.
Relates ES-10929