-
Notifications
You must be signed in to change notification settings - Fork 25.3k
Mute tests in SSLErrorMessageFileTests that rely on Security Manager #130474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
gmjehovich
wants to merge
6
commits into
elastic:main
Choose a base branch
from
gmjehovich:mute_tests
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+16
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pinging @elastic/es-security (Team:Security) |
Pinging @elastic/es-core-infra (Team:Core/Infra) |
n1v0lg
reviewed
Jul 2, 2025
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/Security.java
Outdated
Show resolved
Hide resolved
n1v0lg
approved these changes
Jul 2, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-backport
Automatically create backport pull requests when merged
:Core/Infra/Entitlements
Entitlements infrastructure
>non-issue
:Security/TLS
SSL/TLS, Certificates
Team:Core/Infra
Meta label for core/infra team
Team:Security
Meta label for security team
v8.17.8
v8.18.3
v8.19.0
v9.0.2
v9.1.0
v9.2.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR mutes tests in
SSLErrorMessageFileTests
that are failing due to their reliance on Security Manager, which has been replaced by Entitlements in ES.There is no way to use Entitlements in unit testing. Therefore, we need to mute these tests until Entitlements is enabled for unit tests. The original test failure tickets have been reassigned to the Core Infra team, who will own unmuting the test once Entitlements is enabled in unit testing.
References #127192 #127193 #127190