Skip to content

Add fast path for single value in VALUES aggregator #130510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Add fast path for single value in VALUES aggregator #130510

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5860c6e
Add fast path for single value in VALUES
dnhatn Jul 3, 2025
90c3463
Update docs/changelog/130510.yaml
dnhatn Jul 3, 2025
5a7a5c7
naming
dnhatn Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions docs/changelog/130510.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
pr: 130510
summary: Add fast path for single value in VALUES aggregator
area: ES|QL
type: enhancement
issues: []
94 changes: 68 additions & 26 deletions ...rc/main/generated-src/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions .../src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesDoubleAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions ...e/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesFloatAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions ...ute/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesIntAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 7 additions & 5 deletions ...te/src/main/generated-src/org/elasticsearch/compute/aggregation/ValuesLongAggregator.java
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

12 changes: 6 additions & 6 deletions ...ompute/src/main/java/org/elasticsearch/compute/aggregation/ValuesBytesRefAggregators.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ public void add(int positionOffset, IntArrayBlock groupIds) {
int valuesStart = ordinalIds.getFirstValueIndex(groupPosition + positionOffset);
int valuesEnd = valuesStart + ordinalIds.getValueCount(groupPosition + positionOffset);
for (int v = valuesStart; v < valuesEnd; v++) {
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(v)));
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(v)));
}
}
}
Expand All @@ -77,7 +77,7 @@ public void add(int positionOffset, IntBigArrayBlock groupIds) {
int valuesStart = ordinalIds.getFirstValueIndex(groupPosition + positionOffset);
int valuesEnd = valuesStart + ordinalIds.getValueCount(groupPosition + positionOffset);
for (int v = valuesStart; v < valuesEnd; v++) {
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(v)));
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(v)));
}
}
}
Expand All @@ -93,7 +93,7 @@ public void add(int positionOffset, IntVector groupIds) {
int valuesStart = ordinalIds.getFirstValueIndex(groupPosition + positionOffset);
int valuesEnd = valuesStart + ordinalIds.getValueCount(groupPosition + positionOffset);
for (int v = valuesStart; v < valuesEnd; v++) {
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(v)));
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(v)));
}
}
}
Expand Down Expand Up @@ -135,7 +135,7 @@ public void add(int positionOffset, IntArrayBlock groupIds) {
int groupEnd = groupStart + groupIds.getValueCount(groupPosition);
for (int g = groupStart; g < groupEnd; g++) {
int groupId = groupIds.getInt(g);
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
}
}
}
Expand All @@ -150,7 +150,7 @@ public void add(int positionOffset, IntBigArrayBlock groupIds) {
int groupEnd = groupStart + groupIds.getValueCount(groupPosition);
for (int g = groupStart; g < groupEnd; g++) {
int groupId = groupIds.getInt(g);
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
}
}
}
Expand All @@ -159,7 +159,7 @@ public void add(int positionOffset, IntBigArrayBlock groupIds) {
public void add(int positionOffset, IntVector groupIds) {
for (int groupPosition = 0; groupPosition < groupIds.getPositionCount(); groupPosition++) {
int groupId = groupIds.getInt(groupPosition);
state.values.add(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
state.addValue(groupId, hashIds.getInt(ordinalIds.getInt(groupPosition + positionOffset)));
}
}

Expand Down
Loading
Loading