Don't accept clustersPerNeighborhood lower than 2 #130526
Merged
+55
−36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iverase
added
>non-issue
:Search Relevance/Search
|
Pinging @elastic/es-search-relevance (Team:Search Relevance) |
elasticsearchmachine
added
the
Team:Search Relevance
iverase
changed the title
|
I am waiting on #130490 as it will affect this PR. |
# Conflicts: # server/src/main/java/org/elasticsearch/index/codec/vectors/cluster/KMeansLocal.java
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This tests are failing when clustersPerNeighborhood is equal to cero as we try to get the best cetroid using the neighbours, but the object is empty. I got a different failure if neighbour are 1 because we cannot then have SOAR assigments.
Therefore I have refactor the code a bit to prevent setting clustersPerNeighborhood < 2.
fixes #130258
fixes #130497