-
Notifications
You must be signed in to change notification settings - Fork 25.3k
[8.19] Simplified Linear and RRF Retrievers Docs #130842
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[8.19] Simplified Linear and RRF Retrievers Docs #130842
Conversation
Documentation preview: |
@@ -1277,59 +1547,65 @@ The output of which, albeit a bit verbose, will provide all the necessary info t | |||
"_score": 0.5, | |||
"_explanation": { | |||
"value": 0.5, | |||
"description": "rrf score: [0.5] computed for initial ranks [0, 1] with rankConstant: [1] as sum of [1 / (rank + rankConstant)] for each query", | |||
"description": "sum of:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change is not related to the backport. The actual response for this example did not match what was here before. Did the test for this example ever pass? Why did this change? I have no idea 🤷♂️ . Perhaps the test for this example wasn't executing for some reason, and the changes I added in the backport inadvertently "fixed the glitch". However the scenario arose, I fixed the test to get green CI for this backport.
What I can say for sure is that the response for this example was not influenced by what I added to the docs or the addition of the multi-field query format. I tested this same example on 8.18 manually and got the same response as 8.19.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this has actually changed elsewhere, but approving this as it can be updated if the unrelated issue is fixed down the line.
Pinging @elastic/es-docs (Team:Docs) |
Pinging @elastic/search-eng (Team:SearchOrg) |
Pinging @elastic/search-relevance (Team:Search - Relevance) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
@@ -1277,59 +1547,65 @@ The output of which, albeit a bit verbose, will provide all the necessary info t | |||
"_score": 0.5, | |||
"_explanation": { | |||
"value": 0.5, | |||
"description": "rrf score: [0.5] computed for initial ranks [0, 1] with rankConstant: [1] as sum of [1 / (rank + rankConstant)] for each query", | |||
"description": "sum of:", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears this has actually changed elsewhere, but approving this as it can be updated if the unrelated issue is fixed down the line.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per the preview, your subheadings were missing some tags and therefore they sat at the same level as the parent.
My suggestions should fix that. Thanks @Mikep86!
Manual backport of #130559