[ES|QL] Fix aggregate_metric_double sorting and mv_expand issues #131658
+565
−274
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes a bug when sorting on multiple indices, where one index contains an aggregate_metric_double field, but at least one other index does not contain that field. The root cause being that the aggregate_metric_double field, when not present in a doc, will be encoded as a NullBlock (1 value), but later on decoded as an AggregateMetricDouble block (which expects to decode 4 values, even if they're all null). It also adds an implementation for MV_EXPAND so it just returns the existing block instead of erroring out, as multi-values are not supported for AggregateMetricDoubleBlock.
elasticsearchmachine
added
the
Team:Analytics
|
Pinging @elastic/es-analytical-engine (Team:Analytics) |
|
Hi @limotova, I've created a changelog YAML for you. |
|
Pinging @elastic/es-storage-engine (Team:StorageEngine) |
dnhatn
approved these changes
Jul 22, 2025
limotova
added
auto-backport
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes a bug when sorting on multiple indices, where one index contains an aggregate_metric_double field, but at least one other index does not contain that field.
The root issue being that the aggregate_metric_double field, when not present in a doc, will be encoded as a NullBlock (1 value), but later on decoded as an AggregateMetricDouble block (which expects to decode 4 values, even if they're all null).
It also adds an implementation for MV_EXPAND so it just returns the existing block instead of erroring out, as multi-values are not supported for AggregateMetricDoubleBlock.