Skip to content

[ML] Fix skipping ML upgrade tests on incompatible versions of Linux #131681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: 8.19
Choose a base branch
from

Conversation

davidkyle
Copy link
Member

@davidkyle davidkyle commented Jul 22, 2025

Older builds of ml cannot run on certain newer Linux's due to an incompatible syscall, the build logic has checks against the libc version and will skip ml tests in that situation. See

public static boolean isMlCompatible(Version version) {

The logic is good but the skip property was missing crucial wildcard for the DFA yaml tests in 90_ml_data_frame_analytics_crud.

Closes #130818 #130764 #130763 #130766

@davidkyle davidkyle added >test-failure Triaged test failures from CI :ml Machine learning auto-backport Automatically create backport pull requests when merged test-full-bwc Trigger full BWC version matrix tests v8.19.1 v8.18.5 labels Jul 22, 2025
@elasticsearchmachine elasticsearchmachine added Team:ML Meta label for the ML team needs:risk Requires assignment of a risk label (low, medium, blocker) labels Jul 22, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/ml-core (Team:ML)

@davidkyle davidkyle added >test Issues or PRs that are addressing/adding tests and removed needs:risk Requires assignment of a risk label (low, medium, blocker) >test-failure Triaged test failures from CI labels Jul 22, 2025
@elasticsearchmachine elasticsearchmachine added the needs:risk Requires assignment of a risk label (low, medium, blocker) label Jul 22, 2025
@davidkyle davidkyle removed the needs:risk Requires assignment of a risk label (low, medium, blocker) label Jul 22, 2025
@davidkyle davidkyle changed the title Fix skip [ML] Fix skipping ML upgrade tests on incompatible versions of Linux Jul 22, 2025
@davidkyle davidkyle enabled auto-merge (squash) July 23, 2025 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-backport Automatically create backport pull requests when merged :ml Machine learning Team:ML Meta label for the ML team >test Issues or PRs that are addressing/adding tests test-full-bwc Trigger full BWC version matrix tests v8.18.5 v8.19.1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants