Add extension points to remediate index metadata in during snapshot restore #131706
+78
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbaiera
added
:Distributed Coordination/Snapshot/Restore
elasticsearchmachine
added
the
Team:Distributed Coordination
|
Pinging @elastic/es-distributed-coordination (Team:Distributed Coordination) |
|
Hi @jbaiera, I've created a changelog YAML for you. |
elasticsearchmachine
added
the
serverless-linked
DaveCTurner
requested changes
Jul 22, 2025
There was a problem hiding this comment.
Production change seems fine to me. However I don't think SnapshotResiliencyTests are quite the right place for this. Instead, could we add a test case to RestoreSnapshotIT (or maybe another AbstractSnapshotIntegTestCase?) covering this specific change. I'd want us to be injecting the transformer via a plugin (i.e. overriding org.elasticsearch.test.ESIntegTestCase#nodePlugins).
DaveCTurner
reviewed
Jul 22, 2025
dakrone
reviewed
Jul 22, 2025
|
|
||
| import org.elasticsearch.cluster.metadata.IndexMetadata; | ||
|
|
||
| public interface IndexMetadataRestoreTransformer { |
There was a problem hiding this comment.
Can you add javadocs for this interface?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new SPI to allow plugins to hook into the snapshot restore process in order to remediate index metadata before accepting it into the cluster state.