Skip to content

Update cache weight setting logic and calculations in ApiKeyService.java #131777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Update cache weight setting logic and calculations in ApiKeyService.java #131777

wants to merge 5 commits into from
+10 −5

Conversation

mjmbischoff
Copy link
Contributor

  • use long
  • use weight vs count
  • prevent (unlikely) overflow

encountered / spun out of #130964

@mjmbischoff
Update cache weight calculations
4dbe9aa 
- use `long`
- use weight vs count
- prevent (unlikely) overflow
@elasticsearchmachine elasticsearchmachine added v9.2.0 external-contributor Pull request authored by a developer outside the Elasticsearch team labels Jul 23, 2025
mjmbischoff added a commit to mjmbischoff/elasticsearch that referenced this pull request Jul 23, 2025
@mjmbischoff
Reverting changes to ApiKeyService as it's spun out into it's own PR e…
efc5e20 
…lastic#131777
@mjmbischoff mjmbischoff changed the title Update cache weight calculations Update cache weight setting logic and calculations in ApiKeyService.java Jul 23, 2025
@mjmbischoff mjmbischoff marked this pull request as ready for review July 23, 2025 22:14
@elasticsearchmachine elasticsearchmachine added the needs:triage Requires assignment of a team area label label Jul 23, 2025
@mjmbischoff mjmbischoff added the :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) label Jul 24, 2025
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team and removed needs:triage Requires assignment of a team area label labels Jul 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

@mjmbischoff mjmbischoff added >bug needs:triage Requires assignment of a team area label and removed Team:Security Meta label for security team labels Jul 24, 2025
@elasticsearchmachine elasticsearchmachine added Team:Security Meta label for security team and removed needs:triage Requires assignment of a team area label labels Jul 24, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @mjmbischoff, I've created a changelog YAML for you.

@mjmbischoff mjmbischoff self-assigned this Jul 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@mjmbischoff mjmbischoff

Labels
>bug external-contributor Pull request authored by a developer outside the Elasticsearch team :Security/Authentication Logging in, Usernames/passwords, Realms (Native/LDAP/AD/SAML/PKI/etc) Team:Security Meta label for security team v9.2.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mjmbischoff @elasticsearchmachine