Handling access tokens #133106
Merged
Handling access tokens #133106
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elasticsearchmachine
added
needs:triage
ankit--sethi
added
:Security/Security
|
Pinging @elastic/es-security (Team:Security) |
elasticsearchmachine
added
the
serverless-linked
…ture/session-tokens
…ture/session-tokens
...gin/security/src/main/java/org/elasticsearch/xpack/security/authc/AuthenticationService.java
Outdated
Show resolved
Hide resolved
…om-authenticator-chain
…ture/session-tokens
…' into feature/session-tokens # Conflicts: # x-pack/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authc/apikey/CustomTokenAuthenticator.java # x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/authc/AuthenticationService.java
...ck/plugin/core/src/main/java/org/elasticsearch/xpack/core/security/authc/Authentication.java
Outdated
Show resolved
Hide resolved
|
|
||
| public class PluggableAuthenticatorChain implements Authenticator { | ||
|
|
||
| public static final PluggableAuthenticatorChain EMPTY = new PluggableAuthenticatorChain(List.of()); |
There was a problem hiding this comment.
This is only used in test classes. Initially I had different idea, but went with other logic and checking if there are any custom authenticators in the chain. We can remove it.
...curity/src/main/java/org/elasticsearch/xpack/security/authc/PluggableAuthenticatorChain.java
Outdated
Show resolved
Hide resolved
...curity/src/main/java/org/elasticsearch/xpack/security/authc/PluggableAuthenticatorChain.java
Show resolved
Hide resolved
…ture/session-tokens
…ture/session-tokens
x-pack/plugin/security/src/main/java/org/elasticsearch/xpack/security/Security.java
Show resolved
Hide resolved
slobodanadamovic
approved these changes
Sep 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce the notion of
PluggableAuthenticatorChainthat allows a series of custom authenticators to be plugged in, each extending theCustomAuthenticatorinterface. Consequently we no longer needPluggableApiKeyAuthenticator.