- 
                Notifications
    
You must be signed in to change notification settings  - Fork 25.6k
 
[ES-12998] Invoking gradle continue flag on periodic runs to allow for more information on test failures #136900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…search into neilbhavsar/ES-13020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We just need to move this change to the .buildkite/pipelines/periodic.template.yml to avoid overriding it. See my other comment for details.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
This should be backported to the all active branches.
| steps: | ||
| - label: "{{matrix.FWC_VERSION}} / fwc" | ||
| command: .ci/scripts/run-gradle.sh -Dbwc.checkout.align=true v$$FWC_VERSION#fwcTest -Dtests.bwc.snapshot=false | ||
| command: .ci/scripts/run-gradle.sh --continue -Dbwc.checkout.align=true v$$FWC_VERSION#fwcTest -Dtests.bwc.snapshot=false | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good catch with adding this to FwC periodic builds as well.
| 
           Pinging @elastic/es-delivery (Team:Delivery)  | 
    
          💔 Backport failedThe backport operation could not be completed due to the following error: You can use sqren/backport to manually backport by running   | 
    
…r more information on test failures (elastic#136900) * Add --continue flag to invoke maven when a task failure has been hit so that we can see the outcome of more testing over time.
…r more information on test failures (elastic#136900) * Add --continue flag to invoke maven when a task failure has been hit so that we can see the outcome of more testing over time. (cherry picked from commit 78b4f85) # Conflicts: # .buildkite/pipelines/periodic.yml
…r more information on test failures (elastic#136900) * Add --continue flag to invoke maven when a task failure has been hit so that we can see the outcome of more testing over time. (cherry picked from commit 78b4f85) # Conflicts: # .buildkite/pipelines/periodic.yml
          💚 All backports created successfully
 Questions ?Please refer to the Backport tool documentation  | 
    
…r more information on test failures (#136900) (#137354) * Add --continue flag to invoke maven when a task failure has been hit so that we can see the outcome of more testing over time. (cherry picked from commit 78b4f85) # Conflicts: # .buildkite/pipelines/periodic.template.yml # .buildkite/pipelines/periodic.yml
…r more information on test failures (elastic#136900) * Add --continue flag to invoke maven when a task failure has been hit so that we can see the outcome of more testing over time.
Updating perioidic.yml file to add --continue on run-gradle.sh invocations that invoke testing to allow for gradle tasks to continue when tests fail. This will allow for more insight into failures and potentially help triage.