-
Notifications
You must be signed in to change notification settings - Fork 25.6k
Add audit log testing for cert-based cross-cluster authentication #137302
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hi @gmjehovich, I've created a changelog YAML for you. |
|
Pinging @elastic/es-security (Team:Security) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for incorporating the suggestions from the other PR!
| return client().performRequest(request); | ||
| } | ||
|
|
||
| private String extractJsonValue(String jsonLine, String fieldName) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: since we only use this for timestamp it could be customized for that extractAuditLogTimestamp maybe?
Original PR: #137225
Opened this one on a feature branch instead of my fork's main branch.
Add audit log assertions to
RemoteClusterSecurityCrossClusterApiKeySigningIT.