Skip to content

Conversation

@gmjehovich
Copy link
Contributor

Original PR: #137225
Opened this one on a feature branch instead of my fork's main branch.

Add audit log assertions to RemoteClusterSecurityCrossClusterApiKeySigningIT.

@gmjehovich gmjehovich added >enhancement :Security/Security Security issues without another label Team:Security Meta label for security team labels Oct 28, 2025
@elasticsearchmachine
Copy link
Collaborator

Hi @gmjehovich, I've created a changelog YAML for you.

@gmjehovich gmjehovich requested a review from jfreden October 29, 2025 00:04
@gmjehovich gmjehovich marked this pull request as ready for review October 29, 2025 00:04
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-security (Team:Security)

Copy link
Contributor

@jfreden jfreden left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for incorporating the suggestions from the other PR!

return client().performRequest(request);
}

private String extractJsonValue(String jsonLine, String fieldName) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: since we only use this for timestamp it could be customized for that extractAuditLogTimestamp maybe?

@gmjehovich gmjehovich merged commit e1c852b into elastic:main Nov 2, 2025
41 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

>enhancement :Security/Security Security issues without another label Team:Security Meta label for security team v9.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants