Evaluate random samples for all rerouted indices #137347
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masseyke
added
>non-issue
:Data Management/Ingest Node
elasticsearchmachine
added
the
Team:Data Management
Collaborator
|
Pinging @elastic/es-data-management (Team:Data Management) |
seanzatzdev
approved these changes
Oct 30, 2025
Contributor
seanzatzdev
left a comment
seanzatzdev
left a comment
There was a problem hiding this comment.
Thanks for the earlier discussion offline, lgtm!!
masseyke
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change checks for a sampling config associated with any index a request has passed through (as opposed to just the index the user initially sent the data to). Regardless of which sample matches (and multiple of them can), it stores the original user data. If an index request is rerouted to multiple indices, it will be evaluated against the sampling configuration of each index it is rerouted to, meaning that the original document could wind up in multiple samples.