Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update docs about EQL CCS #91542

Merged
merged 10 commits into from
Nov 15, 2022
Merged

Conversation

luigidellaquila
Copy link
Contributor

No description provided.

@github-actions
Copy link
Contributor

Documentation preview:

@luigidellaquila luigidellaquila added >docs General docs changes :Analytics/EQL EQL querying labels Nov 14, 2022
@luigidellaquila luigidellaquila marked this pull request as ready for review November 14, 2022 11:54
@elasticsearchmachine elasticsearchmachine added Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team labels Nov 14, 2022
@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-docs (Team:Docs)

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-ql (Team:QL)

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've left a proposal regarding the wording:

  • instead of pointing to the ccs versions matrix, I've kept the same wording as before with an exception regarding the two versions it applies
  • I removed the redirection to one message only. This combined with a simpler message regarding CCS versions, I'm hoping it aims for a simpler/clearer user experience when consuming the documentation.

@luigidellaquila
Copy link
Contributor Author

Thanks @astefan, it makes the message more readable and straight-forward.
I committed you proposed changes as they are

Comment on lines 800 to 805
The EQL search API supports <<modules-cross-cluster-search,cross-cluster search>>. However, the local and <<remote-clusters,remote clusters>> must use the same {es} version if they have versions prior to 7.17.7 (included) or prior to 8.5.1 (included).
search>> with <<remote-clusters,remote clusters>> v 7.17.8+,
and limited to <<ccs-supported-configurations>>.
However, if local node has version prior to 7.17.8 or 8.5.2, <<remote-clusters,remote clusters>>
must be the same {es} version to run <<modules-cross-cluster-search,cross-cluster
search>>.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This one is not right. It got messed up when the suggestion was applied.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixing

Copy link
Contributor

@astefan astefan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@bpintea bpintea left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@luigidellaquila luigidellaquila merged commit 6e5c3d9 into elastic:main Nov 15, 2022
fcofdez pushed a commit to fcofdez/elasticsearch that referenced this pull request Nov 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Analytics/EQL EQL querying >docs General docs changes Team:Docs Meta label for docs team Team:QL (Deprecated) Meta label for query languages team v7.17.8 v8.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants