Skip to content

apm: Add integration policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl #13348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

apm: Add integration policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl #13348

wants to merge 3 commits into from

Conversation

carsonip
Copy link
Member

@carsonip carsonip commented Mar 28, 2025 •
edited
Loading

Proposed commit message

apm: Add policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Screenshots

@carsonip carsonip changed the title apm: Add config for tail-based sampling TTL apm: Add integration policy variable tail_sampling_ttl to configure apm-server.sampling.tail.ttl Mar 28, 2025
carsonip
carsonip commented Mar 28, 2025
View reviewed changes
packages/apm/manifest.yml
@@ -1,7 +1,7 @@
format_version: 3.1.0
name: apm
title: Elastic APM
version: 9.0.0-preview-1738343125
version: 9.1.0-preview-1743184896
description: Monitor, detect, and diagnose complex application performance issues.
type: integration
categories: ["elastic_stack", "monitoring"]
Copy link
Member Author

@carsonip carsonip Mar 28, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: do i have to bump the kibana version constraint version: ^9.0.0 to 9.1.0? I don't think it is required

packages/apm/agent/input/template.yml.hbs Outdated
@@ -70,5 +70,8 @@ apm-server:
{{#if tail_sampling_interval}}
interval: {{tail_sampling_interval}}
{{/if}}
{{#if tail_sampling_ttl}}
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Q: not too clear to me why we need the if for tail_sampling_interval, but I copied it anyway as they are similar.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm convinced it isn't needed after testing without the if. Removing.

@andrewkroh andrewkroh added the Integration:apm Elastic APM label Mar 28, 2025
@carsonip
Copy link
Member Author

carsonip commented Apr 8, 2025

Tested with elastic-package and EA, confirmed that in the computed config ttl is present with default value

        sampling:
            tail:
                enabled: true
                interval: 1m
                policies:
                    - sample_rate: 0.1
                storage_limit: 0GB
                ttl: 30m
        shutdown_timeout: 30s
        ssl:

@elasticmachine
Copy link

💚 Build Succeeded

History

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

@carsonip carsonip mentioned this pull request Apr 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Integration:apm Elastic APM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@carsonip @elasticmachine @andrewkroh