-
Notifications
You must be signed in to change notification settings - Fork 452
Document Journald on docker #13597
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Document Journald on docker #13597
Conversation
096c12c
to
e51a82f
Compare
e51a82f
to
eb5332a
Compare
🚀 Benchmarks reportTo see the full report comment with |
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
Pinging @elastic/sec-deployment-and-devices (Team:Security-Deployment and Devices) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder what would it cost us (in terms of the image size) to include journalctl in our regular Ubuntu/Ubi/Wolfi images?
Did we look into it?
I think it's not the best user experience if ask to use the complete image for such a common use-case.
I don't think we (data-plane) looked into it. IIRC when the change to use I did a quick test by just installing the Dockerfile
FROM docker.elastic.co/elastic-agent/elastic-agent-wolfi:9.0.0
USER root
RUN apk update
RUN apk add systemd
ENTRYPOINT ["/usr/bin/journalctl", "--version"]
I like the idea of adding I'd merge this PR as it is, because it documents the current state and how to use the journald input with Elastic-Agent, allowing users to already benefit from it. Once we have a new release of Elastic-Agent with |
So, the size increase for Wolfi is only about 10%. I'm fine with merging this PR as it is but it should be addressed by extending all of our Docker images and having |
I'm already working on it, you can follow this issue: elastic/beats#44040. The Beats PR is up, I'll work on Elastic-Agent soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving but I have requested a couple of changes.
💔 Build Failed
Failed CI StepsHistory
cc @belimawr |
|
@belimawr Do we still need to merge this since we about to solve it with elastic/elastic-agent#7995 ? |
Increasing the size of the elastic-agent container by 170 MB is a definite no-go right now. We are trying to slowly bring that container size down to something that isn't ludicrous and adding on 170 MB goes against that. PM would need to be OK with that size increase and I don't think they will be. |
Proposed commit message
Document the requirements to read from Journald when using Elastic-Agent in Docker for the following integrations:
Checklist
changelog.yml
file.## Author's ChecklistHow to test this PR locally
Related issues
elastic-agent-complete
docker image and thejournalctl
version constraint. #13019## Screenshots