Skip to content

[okta] Fix dashboard filters #13761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 7, 2025
Merged

Conversation

navnit-elastic
Copy link
Contributor

@navnit-elastic navnit-elastic commented May 2, 2025

Proposed commit message

okta: fix dashboard failure events filters.

This change modifies okta system dashboard to add a top level dataset 
filter that prevents visualizations from rendering data outside of Okta.

The "Okta Failure Events" search visualization was not showing any data 
due to the event.outcome: FAILURE filter. This update modifies the 
visualization to use a lowercase filter value (failure) to ensure data 
is correctly populated, following the expected ECS value format.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Clone integrations repo.
Install elastic package locally.
Start elastic stack using elastic-package.
Move to integrations/packages/okta directory.
Run the following command to run tests.

elastic-package test

Related issues

Screenshots

okta-system-screenshot

@navnit-elastic navnit-elastic added Integration:okta Okta dashboard Relates to a Kibana dashboard bug, enhancement, or modification. bugfix Pull request that fixes a bug issue Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors] labels May 2, 2025
@navnit-elastic navnit-elastic self-assigned this May 2, 2025
@navnit-elastic navnit-elastic requested a review from a team as a code owner May 2, 2025 08:44
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

@elastic-vault-github-plugin-prod

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

Conflicts:
	packages/okta/changelog.yml
	packages/okta/manifest.yml
Copy link
Contributor

@efd6 efd6 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM after changelog update (and corresponding change to proposed commit message).

@@ -4,6 +4,11 @@
- description: Retain Okta Domain value in `host.name` where possible.
type: enhancement
link: https://github.com/elastic/integrations/pull/13721
- version: "3.6.2"
changes:
- description: Fix dashboard filters.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- description: Fix dashboard filters.
- description: Fix dashboard failure events filters.

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @navnit-elastic

@navnit-elastic navnit-elastic merged commit 57858f7 into elastic:main May 7, 2025
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Pull request that fixes a bug issue dashboard Relates to a Kibana dashboard bug, enhancement, or modification. Integration:okta Okta Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Team:Sit-Crest Crest developers on the Security Integrations team [elastic/sit-crest-contractors]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Okta]: Incorrect filters in Okta Dashboard elements
3 participants