Skip to content

Align datatypes with ECS #13781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 7 commits into
base: main
Choose a base branch
from
Open

Conversation

ash-darin
Copy link

@ash-darin ash-darin commented May 5, 2025

Align datatypes with ECS

Changed the datatype for the fields

  • event.module
  • event.dataset

from constant_keyword to keyword. The usage of constant_keyword does not conform to ECS:

https://www.elastic.co/docs/reference/ecs/ecs-event#field-event-dataset
https://www.elastic.co/docs/reference/ecs/ecs-event#field-event-module

ECS compliance is recommended per Development guidelines:

https://www.elastic.co/docs/extend/integrations/general-guidelines#_ecs_compliance

An integration package should be compliant with the most recent version of ECS.

Checklist

  • I have added an entry to the package's changelog.yml file.

@ash-darin ash-darin changed the title Fix darktrace Align datatypes with ECS May 5, 2025
@ash-darin ash-darin marked this pull request as ready for review May 5, 2025 09:27
@ash-darin ash-darin requested a review from a team as a code owner May 5, 2025 09:27
@andrewkroh andrewkroh added Integration:darktrace Darktrace Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] labels May 5, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Integration:darktrace Darktrace Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants