Add enable_batch_api option in azure resource metrics #13783
+54
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🚀 Benchmarks reportTo see the full report comment with |
💚 Build Succeeded
|
|
andrewkroh
added
Integration:azure_metrics
zmoog
reviewed
May 6, 2025
Comment on lines
+70
to
+80
| - name: enable_batch_api | ||
| type: bool | ||
| title: Enable Batch Api | ||
| description: > | ||
| When enabled, the azure batch api will be used | ||
| to fetch metrics of multiple resources in one api call. | ||
| Enable this when facing scalability issues. | ||
| multi: false | ||
| required: false | ||
| show_user: false | ||
| default: false |
There was a problem hiding this comment.
nits: minor capitalization suggestions.
Suggested change
| - name: enable_batch_api | |
| type: bool | |
| title: Enable Batch Api | |
| description: > | |
| When enabled, the azure batch api will be used | |
| to fetch metrics of multiple resources in one api call. | |
| Enable this when facing scalability issues. | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: false | |
| - name: enable_batch_api | |
| type: bool | |
| title: Enable Batch API | |
| description: > | |
| When enabled, the Azure batch API will be used | |
| to fetch metrics of multiple resources in one API call. | |
| Enable this when facing scalability issues. | |
| multi: false | |
| required: false | |
| show_user: false | |
| default: false |
Comment on lines
+192
to
+196
| `Enable Batch Api` _boolean_ | ||
| : Optional, by default is set to False. Set this to True when facing scalability issues. When configured, the azure batch api will be used | ||
| to fetch metrics of multiple resources in one api call. | ||
| Currently supported data streams are monitor, container_registry, container_instance, container_service, compute_vm, compute_vm_scaleset, database_account and storage_account. | ||
|
|
There was a problem hiding this comment.
nit:
Suggested change
| `Enable Batch Api` _boolean_ | |
| : Optional, by default is set to False. Set this to True when facing scalability issues. When configured, the azure batch api will be used | |
| to fetch metrics of multiple resources in one api call. | |
| Currently supported data streams are monitor, container_registry, container_instance, container_service, compute_vm, compute_vm_scaleset, database_account and storage_account. | |
| `Enable Batch API` _boolean_ | |
| : Optional, by default is set to False. Set this to True when facing scalability issues. When configured, the Azure batch API will be used | |
| to fetch metrics of multiple resources in one API call. | |
| Currently supported data streams are monitor, container_registry, container_instance, container_service, compute_vm, compute_vm_scaleset, database_account and storage_account. | |
| @@ -21,7 +21,7 @@ categories: | |||
| - custom | |||
| conditions: | |||
| kibana: | |||
| version: "^8.12.0 || ^9.0.0" | |||
| version: "^9.0.1" | |||
There was a problem hiding this comment.
This is only partially related to the changes in this PR.
Is it worth backporting the Beats PR to one or more 8.x versions? Possible candidates: 8.17, 8.18, 8.19.
The reason is practical. We will support the last 8.x series (8.19.x?) for a while, as we're still doing for 7.17.x today—to deliver fixes and small improvements.
It's better to do it now than later, while the memory of the changes in the PR is still relatively fresh. We can merge this PR now, and add 8.x compatibility conditions later when the backport(s) is/are merged.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up of beats PR
Proposed commit message
enable_batch_apiconfiguration parameter in azure resource metrics.Checklist
changelog.ymlfile.Author's Checklist
How to test this PR locally
It can be easily tested by installing Azure Resource Metrics. Enable the
enable_batch_apiadvanced setting.Then the metrics will be collected from the azure batch api.
Related issues
Screenshots