-
Notifications
You must be signed in to change notification settings - Fork 464
[qualys_was] Added scripts to convert doubles to long. Added terminate Processor. Added IDs to web app tag list #14322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Pinging @elastic/security-service-integrations (Team:Security-Service Integrations) |
packages/qualys_was/changelog.yml
Outdated
Explicitly cast all long fields to long in case CEL sends them as doubles | ||
Add terminate processor at start of default.yml | ||
Changed web app tags from list of names to list of tag objects with name and id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Explicitly cast all long fields to long in case CEL sends them as doubles | |
Add terminate processor at start of default.yml | |
Changed web app tags from list of names to list of tag objects with name and id | |
Explicitly cast all long fields to long in case the agent sends them as doubles. | |
Terminate ingest pipeline early if agent sends an error message. | |
Change web app tags from list of names to list of tag objects with name and id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
- script: | ||
if: ctx.qualys_was?.vulnerability?.id != null | ||
tag: vul_id_is_long | ||
lang: painless | ||
source: > | ||
if (ctx.qualys_was.vulnerability.id instanceof String) { | ||
ctx.qualys_was.vulnerability.id = Long.parseLong(ctx.qualys_was.vulnerability.id); | ||
} else { | ||
ctx.qualys_was.vulnerability.id = (long)ctx.qualys_was.vulnerability.id; | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we probably want on_failure
s for these.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
- rename: | ||
field: json.detection.webApp.id | ||
tag: rename_webApp_url | ||
target_field: qualys_was.vulnerability.web_app.id |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ignore_missing
?
🚀 Benchmarks reportTo see the full report comment with |
b2ad6d0
to
4a655fb
Compare
4a655fb
to
29e9816
Compare
…for long types. Added terminate processor. Changed tag list to list of objects Added painless script to convert potential double values from cel scripts to longs. Changed web app tags to a list of tags with id and name instead of just a list of names. Added a terminate processor
…uble to long conversions
…ME to reflect new webApp.Tags structure
29e9816
to
c8d5880
Compare
|
💚 Build Succeeded
History
|
Proposed commit message
[qualys_was] Fixed several issues
since tags used to be a list of names and it's now a list of objects with id and name.
Checklist
I have reviewed tips for building integrations and this pull request is aligned with them.
I have verified that all data streams collect metrics or logs.
I have added an entry to my package's
changelog.yml
file.I have verified that Kibana version constraints are current according to guidelines.
I have verified that any added dashboard complies with Kibana's Dashboard good practices
Relates [New Integration] Qualys Web Application Scanning #12008