Skip to content

[qualys_was] Added scripts to convert doubles to long. Added terminate Processor. Added IDs to web app tag list #14322

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

StacieClark-Elastic
Copy link
Member

@StacieClark-Elastic StacieClark-Elastic commented Jun 25, 2025

Proposed commit message

[qualys_was] Fixed several issues

  • Added painless script to convert potential double values from cel scripts to longs.
  • Changed web app tags to a list of tags with id and name instead of just a list of names. This is a breaking change
    since tags used to be a list of names and it's now a list of objects with id and name.
  • Added a terminate processor to beginning of default.yml to fast fail on failing cel script.

Checklist

@StacieClark-Elastic StacieClark-Elastic requested a review from a team as a code owner June 25, 2025 22:32
@StacieClark-Elastic StacieClark-Elastic added breaking change Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations] Integration:qualys_was Qualys Web Application Scanning (WAS) labels Jun 25, 2025
@elasticmachine
Copy link

Pinging @elastic/security-service-integrations (Team:Security-Service Integrations)

Comment on lines 5 to 7
Explicitly cast all long fields to long in case CEL sends them as doubles
Add terminate processor at start of default.yml
Changed web app tags from list of names to list of tag objects with name and id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Explicitly cast all long fields to long in case CEL sends them as doubles
Add terminate processor at start of default.yml
Changed web app tags from list of names to list of tag objects with name and id
Explicitly cast all long fields to long in case the agent sends them as doubles.
Terminate ingest pipeline early if agent sends an error message.
Change web app tags from list of names to list of tag objects with name and id.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Comment on lines +81 to +94
- script:
if: ctx.qualys_was?.vulnerability?.id != null
tag: vul_id_is_long
lang: painless
source: >
if (ctx.qualys_was.vulnerability.id instanceof String) {
ctx.qualys_was.vulnerability.id = Long.parseLong(ctx.qualys_was.vulnerability.id);
} else {
ctx.qualys_was.vulnerability.id = (long)ctx.qualys_was.vulnerability.id;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we probably want on_failures for these.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

- rename:
field: json.detection.webApp.id
tag: rename_webApp_url
target_field: qualys_was.vulnerability.web_app.id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ignore_missing?

@StacieClark-Elastic StacieClark-Elastic enabled auto-merge (squash) June 25, 2025 23:22
@elastic-vault-github-plugin-prod
Copy link

elastic-vault-github-plugin-prod bot commented Jun 26, 2025

🚀 Benchmarks report

To see the full report comment with /test benchmark fullreport

@StacieClark-Elastic StacieClark-Elastic requested a review from efd6 June 26, 2025 02:52
@StacieClark-Elastic StacieClark-Elastic force-pushed the qualys-was-add-terminate-processor branch from b2ad6d0 to 4a655fb Compare June 26, 2025 13:27
@StacieClark-Elastic StacieClark-Elastic self-assigned this Jun 26, 2025
@StacieClark-Elastic StacieClark-Elastic force-pushed the qualys-was-add-terminate-processor branch from 4a655fb to 29e9816 Compare June 27, 2025 18:08
@StacieClark-Elastic StacieClark-Elastic force-pushed the qualys-was-add-terminate-processor branch from 29e9816 to c8d5880 Compare June 27, 2025 20:27
Copy link

@elasticmachine
Copy link

💚 Build Succeeded

History

cc @StacieClark-Elastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking change Integration:qualys_was Qualys Web Application Scanning (WAS) Team:Security-Service Integrations Security Service Integrations team [elastic/security-service-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants