Skip to content

[prometheus_input] Update docs to include information about SSL configuration options #14575

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

devamanv
Copy link
Contributor

@devamanv devamanv commented Jul 17, 2025

Proposed commit message

The PR updates the package README to add information about SSL configuration options.

Checklist

  • I have reviewed tips for building integrations and this pull request is aligned with them.
  • I have verified that all data streams collect metrics or logs.
  • I have added an entry to my package's changelog.yml file.
  • I have verified that Kibana version constraints are current according to guidelines.
  • I have verified that any added dashboard complies with Kibana's Dashboard good practices

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

@devamanv devamanv requested a review from a team as a code owner July 17, 2025 08:27
@andrewkroh andrewkroh added documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:prometheus_input Prometheus Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations] labels Jul 17, 2025
Comment on lines 2 to 6
- version: "0.9.1"
changes:
- description: Update README to include information about SSL configuration.
type: enhancement
link: https://github.com/elastic/integrations/pull/14575
Copy link
Contributor

@mykola-elastic mykola-elastic Jul 18, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

for enhancement should we pop up the minor version, like 0.10.0?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ishleenk17 do we need changelog entry at all just for a doc change?

@mykola-elastic mykola-elastic requested a review from alaudazzi July 18, 2025 07:58
Copy link
Contributor

@alaudazzi alaudazzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a minor editing suggestion, otherwise LGTM.

Copy link
Contributor

@gpop63 gpop63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

Copy link

Copy link
Contributor

@lalit-satapathy lalit-satapathy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link

elasticmachine commented Jul 28, 2025

💔 Build Failed

Failed CI Steps

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation. Applied to PRs that modify *.md files. Integration:prometheus_input Prometheus Input Team:Obs-InfraObs Observability Infrastructure Monitoring team [elastic/obs-infraobs-integrations]
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants