Refactored inject_zeros component in Vislib #1710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } else if (obj.columns) { | ||
| return obj.columns; | ||
| } else { | ||
| return [obj]; |
There was a problem hiding this comment.
What is this condition supposed to represent? Perhaps it would be better to have else if (obj.series) { here?
|
Done |
spalger
pushed a commit
that referenced
this pull request
Oct 17, 2014
Refactored inject_zeros component in Vislib
|
LGTM! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current code for
inject_zeros.jsis a hot mess. This pull request cleans the code up substantially making it much easier to read as well as up-ing the test coverage to 100%.