Allow ordering of bars by count on term aggregation when x axis values are numbers #1968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this ready for review? If so, label it and assign someone. |
…arch sends them. That is, in descending order with the biggest values first. Changed the index which is recorded from the highest to the lowest. So the lowest index position is taken for an x value instead of the highest. In addition, we were not actually sorting by indexed position before, so this fixes that bug.
|
Tests were added in the last commit. |
|
LGTM. merge it. |
stormpython
added a commit
that referenced
this pull request
Dec 1, 2014
Allow ordering of bars by count on term aggregation when x axis values are numbers
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1903.
Currently, when a terms aggregation is applied to a number field (x axis values), vertical bars are not ordered by count. Instead they are ordered lexicographically. This only occurs for number fields.
This pull request removes the sortBy of index positions from ordered_x_keys module which is causing the issue.