Skip to content

Conversation

@github-actions
Copy link
Contributor

No description provided.

@donoghuc donoghuc requested a review from karenzone October 20, 2025 18:27
:version: v9.2.0
:release_date: 2025-10-02
:changelog_url: https://github.com/elastic/logstash-filter-elastic_integration/blob/v9.2.0/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
:include_path: ../include

:version: v4.3.1
:release_date: 2025-09-23
:changelog_url: https://github.com/logstash-plugins/logstash-filter-elasticsearch/blob/v4.3.1/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
:include_path: ../include

The example below reproduces the above example but utilises the query_template.
This query_template represents a full Elasticsearch query DSL and supports the
standard Logstash field substitution syntax. The example below issues
standard {ls} field substitution syntax. The example below issues
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
standard {ls} field substitution syntax. The example below issues
standard {{ls}} field substitution syntax. The example below issues

:version: v4.3.1
:release_date: 2025-09-23
:changelog_url: https://github.com/logstash-plugins/logstash-filter-elasticsearch/blob/v4.3.1/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
:include_path: ../include

:version: v5.6.1
:release_date: 2025-09-30
:changelog_url: https://github.com/logstash-plugins/logstash-integration-jdbc/blob/v5.6.1/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
:include_path: ../include

:version: v11.6.4
:release_date: 2025-08-28
:changelog_url: https://github.com/logstash-plugins/logstash-integration-kafka/blob/v11.6.4/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
:include_path: ../include

:version: v4.1.0
:release_date: 2025-08-18
:changelog_url: https://github.com/logstash-plugins/logstash-integration-snmp/blob/v4.1.0/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
:include_path: ../include

:version: v12.0.7
:release_date: 2025-09-23
:changelog_url: https://github.com/logstash-plugins/logstash-output-elasticsearch/blob/v12.0.7/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
:include_path: ../include


[id="plugins-{type}s-{plugin}-ess"]
==== Hosted {es} Service on Elastic Cloud
==== {ls} to {ech}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
==== {ls} to {ech}
==== {{ls}} to {{ech}}

:version: v11.6.4
:release_date: 2025-08-28
:changelog_url: https://github.com/logstash-plugins/logstash-integration-kafka/blob/v11.6.4/CHANGELOG.md
:include_path: ../../../../logstash/docs/include
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
:include_path: ../../../../logstash/docs/include
https://www.elastic.co/guide/en/logstash/current/dead-letter-queues.html

@donoghuc
Copy link
Member

Thanks @karenzone ! Would you like to commit all these suggestions via the github UI? Or do you want me to update the branch locally and push up all the changes in one commit?

@karenzone
Copy link
Contributor

These PRs don't actually do anything wrt published docs. so please leave it to me.
That's what the "Coordinate with tech writer" step on plugin docs is all about.

So you're all set.

Copy link
Contributor

@karenzone karenzone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DO NOT MERGE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants