Skip to content

Conversation

alexcams
Copy link
Contributor

@alexcams alexcams commented Oct 15, 2025

Release notes

ES Logstash configuration should support encoded and non-encoded api-key formats.

What does this PR do?

Since the http client used for Centrilized Pipeline Management and Stack Monitoring is the one implemented at EX Output plugin as we can see here, and it has been already published, no changes are needed in logstash core code to support both api-key formats.
This PR includes unit tests to prevent future regressions if the plugin client is changed.

Why is it important/What is the impact to the user?

User is now able to use both api-key formats.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • [ ] I have made corresponding changes to the documentation
  • [ ] I have made corresponding change to the default configuration files (and/or docker env variables)
  • I have added tests that prove my fix is effective or that my feature works

Related issues

Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

mergify bot commented Oct 15, 2025

This pull request does not have a backport label. Could you fix it @alexcams? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit.
  • If no backport is necessary, please add the backport-skip label

@alexcams alexcams force-pushed the 18095-support-opaque-api_key-in-ls-core-central-management branch from 9e9e6fe to f38b924 Compare October 15, 2025 10:41
@alexcams alexcams added the backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches label Oct 15, 2025
@alexcams alexcams requested a review from Copilot October 17, 2025 15:17
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds unit tests to ensure both encoded and non-encoded api_key formats are accepted for xpack management Elasticsearch source initialization.

  • Introduces parameterized test contexts for non-encoded and Base64-encoded api_key values.
  • Verifies initialization does not raise errors with either api_key format.

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@alexcams alexcams requested a review from edmocosta October 17, 2025 15:17
@alexcams alexcams force-pushed the 18095-support-opaque-api_key-in-ls-core-central-management branch from f38b924 to e866999 Compare October 17, 2025 16:05
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@alexcams alexcams merged commit a83b7a4 into elastic:main Oct 21, 2025
10 checks passed
Copy link
Contributor

@Mergifyio backport 9.0 9.1 9.2

Copy link
Contributor

mergify bot commented Oct 21, 2025

mergify bot pushed a commit that referenced this pull request Oct 21, 2025
mergify bot pushed a commit that referenced this pull request Oct 21, 2025
mergify bot pushed a commit that referenced this pull request Oct 21, 2025
alexcams added a commit that referenced this pull request Oct 22, 2025
alexcams added a commit that referenced this pull request Oct 22, 2025
alexcams added a commit that referenced this pull request Oct 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport-active-9 Automated backport with mergify to all the active 9.[0-9]+ branches

Projects

None yet

Development

Successfully merging this pull request may close these issues.

support opaque api_key in LS-Core Stack Monitoring

3 participants