-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add encoded/non-encoded auth method to xpack unit tests #18307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add encoded/non-encoded auth method to xpack unit tests #18307
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
This pull request does not have a backport label. Could you fix it @alexcams? 🙏
|
9e9e6fe to
f38b924
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
Adds unit tests to ensure both encoded and non-encoded api_key formats are accepted for xpack management Elasticsearch source initialization.
- Introduces parameterized test contexts for non-encoded and Base64-encoded api_key values.
- Verifies initialization does not raise errors with either api_key format.
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
f38b924 to
e866999
Compare
💚 Build Succeeded
History
|
|
@Mergifyio backport 9.0 9.1 9.2 |
✅ Backports have been created
|
(cherry picked from commit a83b7a4)
(cherry picked from commit a83b7a4)
(cherry picked from commit a83b7a4)
…8325) (cherry picked from commit a83b7a4) Co-authored-by: Álex Cámara Lara <[email protected]>
…8324) (cherry picked from commit a83b7a4) Co-authored-by: Álex Cámara Lara <[email protected]>
…8323) (cherry picked from commit a83b7a4) Co-authored-by: Álex Cámara Lara <[email protected]>
Release notes
ES Logstash configuration should support encoded and non-encoded api-key formats.
What does this PR do?
Since the http client used for Centrilized Pipeline Management and Stack Monitoring is the one implemented at EX Output plugin as we can see here, and it has been already published, no changes are needed in logstash core code to support both api-key formats.
This PR includes unit tests to prevent future regressions if the plugin client is changed.
Why is it important/What is the impact to the user?
User is now able to use both api-key formats.
Checklist
[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files (and/or docker env variables)Related issues